From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] fpswa logging redux
Date: Thu, 12 Dec 2002 19:14:31 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805555@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590709805545@msgid-missing>
Jesse> How about something like this then? It just prints out the
Jesse> isr in addition to the ip for the case of printk, and decodes
Jesse> the right si_code for signals. If this approach looks ok, I
Jesse> can add trap decoding too.
Basically OK with me, however:
o What's the point of declaring fp_fault_info in a header file? It's
used only in one place.
o si_code is NOT a bitmask; it makes no sense at all for
fp_fault_si_code() to OR multiple values together; this makes me
highly suspicious that there is a misunderstanding somewhere...
o Who defined FP_SWASST and FPE_DENORM? I don't recall seeing them
in the ia64 psABI and they definitely look ia64-specific, so their
names should at least be prefixed by a double-underscore
(siginfo.h).
o If you add stuff to asm/siginfo.h, don't forget to update glibc (in
sysdeps/unix/sysv/linux/ia64/bits/siginfo.h).
--david
prev parent reply other threads:[~2002-12-12 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 22:25 [Linux-ia64] fpswa logging redux Jesse Barnes
2002-12-11 23:07 ` Keith Owens
2002-12-11 23:12 ` Jesse Barnes
2002-12-11 23:17 ` Keith Owens
2002-12-11 23:26 ` Jesse Barnes
2002-12-11 23:42 ` David Mosberger
2002-12-12 18:25 ` Jesse Barnes
2002-12-12 19:14 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805555@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.