All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] [Patch] Fix in printk.c
Date: Sat, 18 Jan 2003 01:15:39 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590709805719@msgid-missing> (raw)

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

c99 specifies

<snip>
       [#7] If, within a  translation  unit,  the  same  identifier
       appears   with  both  internal  and  external  linkage,  the
       behavior is undefined.
</snip>

"early_printk" has this type of behaviour in printk.c. Attached/appended patch removes the dependency on the behaviour of the compiler.

thanks,
suresh

diff -Nru linux-2.5.52/kernel/printk.c~ linux-2.5.52/kernel/printk.c
--- linux-2.5.52/kernel/printk.c~	Fri Jan 17 14:53:30 2003
+++ linux-2.5.52/kernel/printk.c	Fri Jan 17 14:53:37 2003
@@ -329,7 +329,7 @@
 	}
 #ifdef CONFIG_IA64_EARLY_PRINTK
 	if (!console_drivers) {
-		static void early_printk (const char *str, size_t len);
+		void early_printk (const char *str, size_t len);
 		early_printk(&LOG_BUF(start), end - start);
 	}
 #endif


[-- Attachment #2: printk.c.diff --]
[-- Type: application/octet-stream, Size: 451 bytes --]

diff -Nru linux-2.5.52/kernel/printk.c~ linux-2.5.52/kernel/printk.c
--- linux-2.5.52/kernel/printk.c~	Fri Jan 17 14:53:30 2003
+++ linux-2.5.52/kernel/printk.c	Fri Jan 17 14:53:37 2003
@@ -329,7 +329,7 @@
 	}
 #ifdef CONFIG_IA64_EARLY_PRINTK
 	if (!console_drivers) {
-		static void early_printk (const char *str, size_t len);
+		void early_printk (const char *str, size_t len);
 		early_printk(&LOG_BUF(start), end - start);
 	}
 #endif

                 reply	other threads:[~2003-01-18  1:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590709805719@msgid-missing \
    --to=suresh.b.siddha@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.