From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] [Patch] Fix in unwind.c
Date: Sat, 18 Jan 2003 07:41:11 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805728@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590709805721@msgid-missing>
>>>>> On Fri, 17 Jan 2003 17:52:18 -0800, "Siddha, Suresh B" <suresh.b.siddha@intel.com> said:
Suresh> Current code in unw_create_gate_table() looks like this:
Suresh> start = (unsigned long) __start_gate_section - segbase; end
Suresh> = (unsigned long) __stop_gate_section - segbase; size = 0;
Suresh> first = lookup(&unw.kernel_table, start); for (entry Suresh> first; entry->start_offset < end; ++entry) size += 3*8 + 8 +
Suresh> 8*UNW_LENGTH(*(u64 *) (segbase + entry->info_offset));
Suresh> Code starts with first unwind kernel table entry for the
Suresh> gate page and goes through all the gate page unwind table
Suresh> entries. Assume if all the gate page unwind table entries
Suresh> comes to the end of kernel unwind table(typically this is
Suresh> what happens because of the order in vmlinux.lds.S), then
Suresh> there is a chance that we go past beyond the kernel unwind
Suresh> table and resulting in a fault while we access "segbase +
Suresh> entry->info_offset".
Yes, I agree that's a bug. I fixed it in the source code, though
slightly differently from what you had in the patch.
Thanks,
--david
prev parent reply other threads:[~2003-01-18 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-18 1:52 [Linux-ia64] [Patch] Fix in unwind.c Siddha, Suresh B
2003-01-18 7:41 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805728@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.