From: Bjorn Helgaas <bjorn_helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] Epca patches
Date: Fri, 24 Jan 2003 16:03:19 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805746@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590709805740@msgid-missing>
> Agree that all the modifications are not ia64-specific.
> However, some of them are 64 bits specific and are related to 64 port:
> - struct board_chan (digiFep1.h, describes a fragment of I/O memory space
> shared between driver and firmware) must be of 128 bytes long exactly.
> - driver's data definitions and insmod MODULE_PARM declarations
> must be consistent.
> - ioremapped memory base addresses data must be long (64 bits).
> - epca module in the kernel sources is not 64 bits
> epca.c
> #if BITS_PER_LONG != 32
> # error FIXME: this driver only works on 32-bit platforms
> #endif
The point is, the epca driver has a maintainer. Changes to it
should go through him.
All the changes you mention can be made in a way that will work
on both 32-bit and 64-bit platforms. And they can almost certainly
be done without all the ugly IA64 #ifdefs. If you head in that
direction, I suspect that the maintainer will be interested in
your changes.
Bjorn
next prev parent reply other threads:[~2003-01-24 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-23 12:53 [Linux-ia64] Epca patches Christian Cotte-Barrot
2003-01-23 17:14 ` Bjorn Helgaas
2003-01-24 15:15 ` Christian Cotte-Barrot
2003-01-24 16:03 ` Bjorn Helgaas [this message]
2003-01-28 14:24 ` Christian Cotte-Barrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805746@msgid-missing \
--to=bjorn_helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.