From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] [patch] 2.4.20-021210 misaligned sal error record
Date: Tue, 25 Feb 2003 01:42:48 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805926@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590709805925@msgid-missing>
>>>>> On Tue, 25 Feb 2003 11:24:35 +1100, Keith Owens <kaos@sgi.com> said:
Keith> - sal_log_mod_error_info_t cache_check_info[16];
Keith> - sal_log_mod_error_info_t tlb_check_info[16];
Keith> - sal_log_mod_error_info_t bus_check_info[16];
Keith> - sal_log_mod_error_info_t reg_file_check_info[16];
Keith> - sal_log_mod_error_info_t ms_check_info[16];
Keith> + sal_log_mod_error_info_t cache_check_info[0];
Keith> + sal_log_mod_error_info_t tlb_check_info[0];
Keith> + sal_log_mod_error_info_t bus_check_info[0];
Keith> + sal_log_mod_error_info_t reg_file_check_info[0];
Keith> + sal_log_mod_error_info_t ms_check_info[0];
Somehow I doubt a declaration of this form is a good idea. If the
records are all variable length, wouldn't it be saner to just declare
this with something along the lines of:
Keith> + sal_log_mod_error_info_t check_info[0];
and then provide separate macros to access the indiviual portions?
--david
next prev parent reply other threads:[~2003-02-25 1:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 0:24 [Linux-ia64] [patch] 2.4.20-021210 misaligned sal error record Keith Owens
2003-02-25 1:42 ` David Mosberger [this message]
2003-02-25 1:53 ` Keith Owens
2003-03-05 0:01 ` David Mosberger
2003-03-05 0:33 ` Keith Owens
2003-03-05 0:45 ` David Mosberger
2003-04-17 22:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805926@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.