All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Re: Port of the posix timers to IA64
Date: Sat, 01 Mar 2003 08:10:03 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590709805949@msgid-missing> (raw)

Hi Eric,

>>>>> On Fri, 28 Feb 2003 10:52:33 +0100, Eric Piel <Eric.Piel@Bull.Net> said:

  Eric> long v;
  Eric> :
  Eric> :
  Eric> if ( v >= (1 << 56)){
  Eric> :
  Eric> }

  Eric> It seems very strange for me that when compiling this part gcc
  Eric> considers that eveything must be converted to int. I have to
  Eric> write 1UL instead of 1 in order to obtain the correct
  Eric> behaviour of the code. I guess you've already come along with
  Eric> such problem.

As Andreas pointed out, that's just how C works.

  Eric> So, first, do you think it's a bug in gcc?

No, gcc is doing the Right Thing.

  Eric> Second should I convert every 1's I see by 1UL's (there are
  Eric> only few but sounds so strange)?

Yes, you need to make sure that anything that gets shifted more than
32 bits has the proper type.  In portable code, I sometimes prefer
to use explicit type-casts, e.g.:

	((size_t) 1) << 48

if the final value needs to be of type size_t, but that's largely
a matter of taste.

	--david


             reply	other threads:[~2003-03-01  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-01  8:10 David Mosberger [this message]
2003-03-03 14:12 ` [Linux-ia64] Re: Port of the posix timers to IA64 Eric Piel
2003-03-05  1:44 ` David Mosberger
2003-03-12 18:37 ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590709805949@msgid-missing \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.