From: Sam Ravnborg <sam@ravnborg.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] offsets.h generation
Date: Tue, 20 May 2003 04:40:20 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590723705956@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590723705941@msgid-missing>
On Tue, May 20, 2003 at 11:26:31AM +1000, Peter Chubb wrote:
>
> OK, here's a patch that does it that way.
Much better, thanks. A few more comments.
I assume that deletion of files in arch/ia64/tools will follow
in seperate cset.
> Because some of the needed
> header files in turn depend on a symbol from offsets.h, I had to
> create a dummy one `by hand' if it didn't previously exist.
> A timestamp file, include/asm-ia64/.offsets.h.stamp, tracks when this
> was done so that 'make' after 'make clean' works; and 'make' after
> 'make' works.
David: Can we remove this circular dependency to get rid of
this ugly workaround?
> -CLEAN_FILES += include/asm-ia64/offsets.h vmlinux.gz bootloader
> +CLEAN_FILES += include/asm-ia64/offsets.h include/asm-ia64/.offsets.h.stamp vmlinux.gz bootloader
Break in two lines.
> -prepare: include/asm-ia64/offsets.h
> +prepare: include/asm-ia64/offsets.h
> +arch/$(ARCH)/kernel/asm-offsets.s: include/asm include/linux/version.h \
> + include/config/MARKER include/asm-$(ARCH)/.offsets.h.stamp
Dependency on include/asm include/linux/version.h and include/config/MARKER
is not needed.
I would prefer to have dependencies for arch/$(ARCH)/kernel/asm-offsets.s
located in kernel/Makefile from where the .s fil is actually build.
Note that it is the general %.s : %.c rule from the top-level
Makefile that kicks in and make sure the .s file get build when needed.
> +
> +include/asm-$(ARCH)/.offsets.h.stamp:
> + [ -f include/asm-$(ARCH)/offsets.h ] || echo "#define IA64_TASK_SIZE 0" > include/asm-$(ARCH)/offsets.h
> + touch $@
So this part should go in kernel/MAkefile as well.
> +#include "../kernel/sigframe.h"
This include should be without "../kernel".
Thanks for cleaning this up.
Sam
next prev parent reply other threads:[~2003-05-20 4:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 4:30 [Linux-ia64] offsets.h generation Peter Chubb
2003-05-19 17:13 ` Sam Ravnborg
2003-05-20 1:26 ` Peter Chubb
2003-05-20 4:40 ` Sam Ravnborg [this message]
2003-05-20 6:31 ` David Mosberger
2003-05-20 9:15 ` Peter Chubb
2003-05-23 1:09 ` Peter Chubb
2003-05-23 1:50 ` David Mosberger
2003-05-26 23:25 ` Peter Chubb
2003-05-27 0:03 ` Peter Chubb
2003-05-27 0:03 ` Peter Chubb
2003-05-31 0:34 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590723705956@msgid-missing \
--to=sam@ravnborg.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.