From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [PATCH] remove pa->va->pa conversion for efi.acpi
Date: Thu, 17 Jul 2003 18:09:50 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105846541211987@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105797540229907@msgid-missing>
>>>>> On Thu, 17 Jul 2003 10:43:19 -0700, "Tolentino, Matthew E" <matthew.e.tolentino@intel.com> said:
>> Does ACPI really guarantee that the table is never stored at physical
>> address 0? If not, then leaving it as a virtual address might be
>> safer. (Yes, I know it's very unlikely for today's system, but at
>> least on ia64, pfn 0 is normal RAM so it seems at least in principle
>> possible to store the ACPI table there).
Matthew> No guarantee that I could find...I suppose this is
Matthew> technically possible. :) However, considering the ACPI
Matthew> routines expect a physical address and thus immediately map
Matthew> it to get the descriptor (either directly with virt_to_phys
Matthew> or via ioremap), this seems redundant. Given the mapping
Matthew> scheme employed, is this still risky? I'd like to reuse
Matthew> the same code path for ia32, but don't want to break ia64.
Note that I'm only pointing this out because I thought there were some
NULL-pointer checks. If it's a physical address, 0 is a valid
address. If it's an (identity-mapped) kernel address, NULL-pointer
checks are OK.
--david
next prev parent reply other threads:[~2003-07-17 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-12 2:00 [PATCH] remove pa->va->pa conversion for efi.acpi Matt Tolentino
2003-07-17 17:43 ` Tolentino, Matthew E
2003-07-17 18:09 ` David Mosberger [this message]
2003-07-17 18:42 ` Tolentino, Matthew E
-- strict thread matches above, loose matches on Subject: below --
2003-07-12 2:00 Matt Tolentino
2003-07-17 17:43 Tolentino, Matthew E
2003-07-17 18:09 ` David Mosberger
2003-07-17 18:42 Tolentino, Matthew E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105846541211987@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.