All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] don't use ld.bias
Date: Wed, 23 Jul 2003 12:00:15 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105896175111168@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105883179830025@msgid-missing>

On Tue, Jul 22, 2003 at 09:40:02PM -0700, Mallick, Asit K wrote:
> It does make sense to not use the ld.bias in the spinlock, it will make
> more cacheline bouncing in a larger SMP system.

it certainly makes a mockery of the comment:

 * Streamlined test_and_set_bit(0, (x)).  We use test-and-test-and-set
 * rather than a simple xchg to avoid writing the cache-line when
 * there is contention.

since there's no real advantage (AIUI) to have the cacheline
clean-exclusive vs dirty-exclusive.

but why not delete this code?  it's under #else /* !NEW_LOCK */ and
NEW_LOCK looks to be the better code as well as the default in 2.5.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

  parent reply	other threads:[~2003-07-23 12:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-21 23:55 [PATCH] don't use ld.bias Jesse Barnes
2003-07-22  0:15 ` Chen, Kenneth W
2003-07-22 13:11 ` Jesse Barnes
2003-07-23  4:40 ` Mallick, Asit K
2003-07-23 12:00 ` Matthew Wilcox [this message]
2003-07-25  1:10 ` David Mosberger
2003-07-25 13:40 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105896175111168@msgid-missing \
    --to=willy@debian.org \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.