Re: [PATCH] sn2 module (& other misc.) fixes

[Christoph Hellwig <hch@infradead.org>]

On Mon, Aug 04, 2003 at 03:01:39PM -0700, Jesse Barnes wrote:
> On Mon, Aug 04, 2003 at 10:54:23PM +0100, Christoph Hellwig wrote:
> > On Mon, Aug 04, 2003 at 02:14:04PM -0700, Jesse Barnes wrote:
> > >  nasid_t master_baseio_nasid = INVALID_NASID;	/* This is the master base I/O nasid */
> > > +EXPORT_SYMBOL(master_nasid);
> > 
> > why is this exported?
> 
> Because no one's ripped it out yet.

So rip it out :)

> > >  char sn_system_serial_number_string[128];
> > >  u64 sn_partition_serial_number;
> > > +EXPORT_SYMBOL(sn_system_serial_number_string);
> > > +EXPORT_SYMBOL(sn_partition_serial_number);
> 
> Modules.
> 
> > >  short physical_node_map[MAX_PHYSNODE_ID];
> > > +EXPORT_SYMBOL(physical_node_map);
> > 
> > Again, what is all this for?
> 
> Modules.

What modules.  My limited grep abilities can't find users and I don't
really see much proper use for those either..