All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Pool <mbp@samba.org>
To: linux-ia64@vger.kernel.org
Subject: [patch] fix "struct irq_desc"
Date: Wed, 06 Aug 2003 06:52:45 +0000	[thread overview]
Message-ID: <marc-linux-ia64-106015279501948@msgid-missing> (raw)

In linux-2.6.0-test2-ia64-030729 configured for generic ia64,
asm-ia64/machvec.h returns a 'struct irq_desc'.  There is a forward
declaration for the struct, but it is never actually defined under
that name, only as irq_desc_t.

This means that the type of ia64_mv_irq_desc is wrong, which causes
the build to break in some files that are built with -Werror.  Really
this is incorrect even for non-generic builds although it does not
actually fail.

This patch puts in both the struct name and _t name:

--- linux-2.6.0test2-ia64/include/linux/irq.h.~1~	2003-07-29 12:05:34.000000000 +1000
+++ linux-2.6.0test2-ia64/include/linux/irq.h	2003-08-06 16:33:30.000000000 +1000
@@ -56,7 +56,7 @@ typedef struct hw_interrupt_type  hw_irq
  *
  * Pad this out to 32 bytes for cache and indexing reasons.
  */
-typedef struct {
+typedef struct irq_desc {
 	unsigned int status;		/* IRQ status */
 	hw_irq_controller *handler;
 	struct irqaction *action;	/* IRQ action list */

Perhaps it would be better to make everything use the irq_desc_t name?
That would require a somewhat larger rearrangement of the headers to
make it visible at that point, but I can do that if desired.

-- 
Martin 

             reply	other threads:[~2003-08-06  6:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-06  6:52 Martin Pool [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-08-06  7:01 [patch] fix "struct irq_desc" David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-106015279501948@msgid-missing \
    --to=mbp@samba.org \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.