All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbarnes@sgi.com (Jesse Barnes)
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] more discontig fun
Date: Mon, 08 Sep 2003 18:31:27 +0000	[thread overview]
Message-ID: <marc-linux-ia64-106304654020526@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105942849830042@msgid-missing>

On Mon, Aug 04, 2003 at 04:27:15PM -0700, David Mosberger wrote:
> >>>>> On Thu, 31 Jul 2003 13:28:57 -0700, jbarnes@sgi.com (Jesse Barnes) said:
> 
> 
>   Jesse> Or would you like to see it cleaned up in some other way?
> 
> I'd like to see it done without changing the interface to efi_memmap_walk().

Rather than calling efi_memmap_walk(filter_rsvd_memory, ...), do you
think it would be ok to move the call into the leaf functions?  E.g.
count_pages would do a if(rsvd_memory(start, end)) return; instead of
getting called from filter_rsvd_memory()?  That would make it easier to
understand and also make it easier to pass the args around.

But maybe a more aggressive cleanup is called for?

Thanks,
Jesse

  parent reply	other threads:[~2003-09-08 18:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-28 21:35 [PATCH] more discontig fun Jesse Barnes
2003-07-30 17:17 ` Jesse Barnes
2003-07-30 23:32 ` Jesse Barnes
2003-07-30 23:53 ` Keith Owens
2003-07-30 23:56 ` Jesse Barnes
2003-07-31  0:32 ` David Mosberger
2003-07-31 20:28 ` Jesse Barnes
2003-08-04 23:27 ` David Mosberger
2003-08-04 23:30 ` Jesse Barnes
2003-09-08 18:31 ` Jesse Barnes [this message]
2003-09-08 18:41 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-106304654020526@msgid-missing \
    --to=jbarnes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.