From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] bail out of sba_init() if no hardware found
Date: Fri, 19 Sep 2003 21:20:47 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106400656632465@msgid-missing> (raw)
This patch against 2.5 gets rid of the following annoying but
harmless messages when booting a generic kernel on a non-ZX1 box:
No IOC for PCI Bus 0000:00 in ACPI
No IOC for PCI Bus 0000:01 in ACPI
...
We just forgot to bail out of the SBA IOMMU init function if it didn't
find any SBA hardware.
=== arch/ia64/hp/common/sba_iommu.c 1.30 vs edited ==--- 1.30/arch/ia64/hp/common/sba_iommu.c Mon Sep 8 14:51:17 2003
+++ edited/arch/ia64/hp/common/sba_iommu.c Fri Sep 19 15:03:40 2003
@@ -1844,18 +1844,19 @@
static void __init
ioc_proc_init(void)
{
- if (ioc_list) {
- struct proc_dir_entry *dir, *entry;
+ struct proc_dir_entry *dir, *entry;
- dir = proc_mkdir("bus/mckinley", 0);
- entry = create_proc_entry(ioc_list->name, 0, dir);
- if (entry)
- entry->proc_fops = &ioc_fops;
-
- entry = create_proc_entry("bitmap", 0, dir);
- if (entry)
- entry->proc_fops = &ioc_map_fops;
- }
+ dir = proc_mkdir("bus/mckinley", 0);
+ if (!dir)
+ return;
+
+ entry = create_proc_entry(ioc_list->name, 0, dir);
+ if (entry)
+ entry->proc_fops = &ioc_fops;
+
+ entry = create_proc_entry("bitmap", 0, dir);
+ if (entry)
+ entry->proc_fops = &ioc_map_fops;
}
#endif
@@ -1941,6 +1942,8 @@
sba_init(void)
{
acpi_bus_register_driver(&acpi_sba_ioc_driver);
+ if (!ioc_list)
+ return 0;
#ifdef CONFIG_PCI
{
reply other threads:[~2003-09-19 21:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106400656632465@msgid-missing \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.