From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Why does salinfo_log_read_cpu use kmalloc?
Date: Wed, 08 Oct 2003 15:55:44 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106562884909569@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106559698807998@msgid-missing>
On Wednesday 08 October 2003 1:08 am, Keith Owens wrote:
> Why does arch/ia64/kernel/salinfo.c::salinfo_log_read_cpu() use
> kmalloc() for the log buffer? The code is running virtual with
> interrupts enabled, SAL_GET_STATE_INFO has no special requirements for
> the buffer attributes, so why not use vmalloc()?
It's usually called via smp_call_function_single(), which uses
an IPI to make it happen on another processor. I thought
this meant the function got called with interrupts disabled,
but I could be wrong.
And yes, I do need to push this to 2.6. It's on my to-do list.
Bjorn
next prev parent reply other threads:[~2003-10-08 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 7:08 Why does salinfo_log_read_cpu use kmalloc? Keith Owens
2003-10-08 11:47 ` Matthew Wilcox
2003-10-08 12:48 ` Keith Owens
2003-10-08 15:55 ` Bjorn Helgaas [this message]
2003-10-09 3:13 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106562884909569@msgid-missing \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.