All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH 2.4.23-pre8]  Remove broken prefetching in free_one_pgd()
Date: Fri, 24 Oct 2003 20:56:31 +0000	[thread overview]
Message-ID: <marc-linux-ia64-106702916015259@msgid-missing> (raw)

This patch was accepted into 2.5.55, attributed to "davej@uk".

This code will prefetch from beyond the end of the page table
being cleared ... which is clearly a bad thing if the page table
in question is allocated from the last page of memory (or precedes
a hole on a discontig mem system).

-Tony Luck

diff -ru linux-2.4.23-pre8/mm/memory.c fix/mm/memory.c
--- linux-2.4.23-pre8/mm/memory.c	Fri Oct 24 13:37:23 2003
+++ fix/mm/memory.c	Fri Oct 24 13:40:47 2003
@@ -120,10 +120,8 @@
 	}
 	pmd = pmd_offset(dir, 0);
 	pgd_clear(dir);
-	for (j = 0; j < PTRS_PER_PMD ; j++) {
-		prefetchw(pmd+j+(PREFETCH_STRIDE/16));
+	for (j = 0; j < PTRS_PER_PMD ; j++)
 		free_one_pmd(pmd+j);
-	}
 	pmd_free(pmd);
 }
 

             reply	other threads:[~2003-10-24 20:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-24 20:56 Luck, Tony [this message]
2003-10-24 22:01 ` [PATCH 2.4.23-pre8] Remove broken prefetching in free_one_pgd() David Mosberger
2003-10-24 22:16 ` Luck, Tony
2003-10-24 22:21 ` David Mosberger
2003-10-25 20:10 ` Pavel Machek
2003-10-26 14:51 ` Dave Jones
2003-10-27  9:52 ` Pavel Machek
2003-10-27 11:58 ` Dave Jones
2003-10-30 20:57 ` Bjorn Helgaas
2003-10-30 21:36 ` Luck, Tony
  -- strict thread matches above, loose matches on Subject: below --
2003-10-24 20:56 Luck, Tony
2003-10-24 22:01 ` David Mosberger
2003-10-25 20:10 ` Pavel Machek
2003-10-26 14:51   ` Dave Jones
2003-10-27  9:52     ` Pavel Machek
2003-10-27 11:58       ` Dave Jones
2003-10-24 22:16 Luck, Tony
2003-10-24 22:21 ` David Mosberger
2003-10-30 20:57   ` Bjorn Helgaas
2003-10-30 21:36 Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-106702916015259@msgid-missing \
    --to=tony.luck@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.