From: "Luck, Tony" <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [PATCH] - prof_cpu_mask problems
Date: Mon, 17 Nov 2003 17:16:01 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106908979932384@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106901123527791@msgid-missing>
> - the IRQ masks are displayed in an unusual format:
> # echo 12345678 >prof_cpu_mask
> # cat prof_cpu_mask
> 5678123400000000
Although it's ugly ... that format seems to have been adopted in
generic code ... here's the code from drivers/base/node.c to
display the bitmap of cpus that belong to a node:
for (k = 0; k < sizeof(cpumask_t)/sizeof(u16); ++k) {
int j = sprintf(buf, "%04hx", (u16)cpus_coerce(tmp));
len += j;
buf += j;
cpus_shift_right(tmp, tmp, 16);
}
There should be some consistency in how bitmaps from cpumask_t
get displayed, but it would also be nice if the 'write' interfaces
to settable cpumasks used the same format that the 'read'
interfaces printed. E.g. I might want to do:
# cat /sys/devices/system/node/node0/cpumap > /proc/irq/prof_cpu_mask
-Tony
next prev parent reply other threads:[~2003-11-17 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-16 19:30 [PATCH] - prof_cpu_mask problems Jack Steiner
2003-11-16 21:25 ` Matthew Wilcox
2003-11-17 17:16 ` Luck, Tony [this message]
2003-11-17 17:30 ` Matthew Wilcox
2003-11-19 21:45 ` Paul Jackson
2003-11-19 22:54 ` William Lee Irwin III
2003-11-20 2:17 ` Paul Jackson
2003-11-20 2:38 ` Paul Jackson
2003-11-20 2:47 ` William Lee Irwin III
2003-11-20 2:59 ` Paul Jackson
2003-11-20 4:47 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106908979932384@msgid-missing \
--to=tony.luck@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.