All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] check user access ok writing
Date: Thu, 27 Nov 2003 05:29:13 +0000	[thread overview]
Message-ID: <marc-linux-ia64-106991103102490@msgid-missing> (raw)

David wrote:
> I see the problem, but the patch is incomplete: even after an
> access_ok()-check, you'll need to use __get_user() to access the
> buffer.

Right you are.  Too bad.  Just bolting an access_ok() on the
front of this code let me get away with not messing with the
existing code.

Keeping patches minimal is easier if they don't have to work ;).

As long as I have to mess with the 'R' parsing code anyway,
might as well use copy_from_user() and clean up these few lines
of code as best I can.

Another patch will be forthcoming.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

             reply	other threads:[~2003-11-27  5:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-27  5:29 Paul Jackson [this message]
2003-11-27 11:51 ` [PATCH] check user access ok writing Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-106991103102490@msgid-missing \
    --to=pj@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.