From: Rusty Russell <rusty@rustcorp.com.au>
To: linux-sound@vger.kernel.org
Subject: Re: [PATCH] Remove one of sound/oss/cmpci.c compile warnings
Date: Sun, 02 Nov 2003 05:05:16 +0000 [thread overview]
Message-ID: <marc-linux-sound-106775423909319@msgid-missing> (raw)
In message <Pine.LNX.4.58.0310282002530.4918@dsl-hkigw4g29.dial.inet.fi> you write:
> Hi!
>
> This patch removes this compile warning:
>
> sound/oss/cmpci.c: In function `cm_release_mixdev':
> sound/oss/cmpci.c:1465: warning: unused variable `s'
>
> GCC doesn't seem to unstand that VALIDATE_STATE macro uses s variable.
> I hope this is correct way to fix this.
Because it doesn't. A better change would be:
VALIDATE_STATE((struct cm_state *)file->private_data);
Or to remove the entire function.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next reply other threads:[~2003-11-02 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-02 5:05 Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-28 18:14 [PATCH] Remove one of sound/oss/cmpci.c compile warnings Petri Koistinen
2003-10-28 18:14 Petri Koistinen
2003-11-02 5:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-sound-106775423909319@msgid-missing \
--to=rusty@rustcorp.com.au \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.