All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@transmeta.com>
To: ultralinux@vger.kernel.org
Subject: Re: 2.1.126 still no sparc64 autofsu
Date: Sat, 14 Nov 1998 08:17:49 +0000	[thread overview]
Message-ID: <marc-linux-ultrasparc-91107863319189@msgid-missing> (raw)

> Okay, I finally had time to take a closer look at this. I've
> found the problem but am not sure what's the best fix.
> 
> The linux/include/linux/auto_fs.h file is shared between the
> autofs.o kernel module and the automount user space daemon
> and contains the following struct:
> 
> struct autofs_packet_missing {
>        struct autofs_packet_hdr hdr;
>        unsigned long wait_queue_token;
>        int len;
>        char name[NAME_MAX+1];
> };
> 
> The problem is that on sparc64 systems the unsigned long
> generates a 64 bit long for the kernel to use, but the
> user space automount expects a 32 bit long and is therefore
> not able to reference the len and name fields properly. I've
> worked around the problem for now by inserting an unused
> long before wait_queue_token in the automount build.
> 
> I thought about providing a patch for the struct since it
> looks like 32 bits should be large enough for the token but
> was then told there are ioctl's which should handle passing
> data between 32 bit user <-> 64 bit kernel space automatically.
> I'm getting lost in the code trying to find them but if they
> exist I guess that's the best place for a fix.
> 
> Perhaps Dave M. or Jakub J. will have a look?
> 
> Thanks for the great work on the ultrapenguin guys. I'm
> really loving these ultra's with hme's at 100mb...
> 

Why is the "long" a different size in kernel and user space?  That
seems buggy.  It's an easy thing to fix, but it seems like the Wrong
Thing[TM].

Changing that to "int" would be just fine, *except* it would break the
protocol for all other platforms.

	-hpa

             reply	other threads:[~1998-11-14  8:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-11-14  8:17 H. Peter Anvin [this message]
1998-11-14 15:45 ` 2.1.126 still no sparc64 autofsu Rich Sahlender
1998-11-14 19:53 ` Jakub Jelinek
1998-11-15  0:52 ` David S. Miller
1998-11-15 23:49 ` H. Peter Anvin
1998-11-15 23:54 ` David S. Miller
1998-11-16  6:47 ` H. Peter Anvin
1998-11-16  6:48 ` Jakub Jelinek
1998-11-16  7:57 ` Jakub Jelinek
1998-11-16  8:37 ` H. Peter Anvin
1998-11-16 20:33 ` Rich Sahlender

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ultrasparc-91107863319189@msgid-missing \
    --to=hpa@transmeta.com \
    --cc=ultralinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.