From: David Miller <davem@twiddle.net>
To: ultralinux@vger.kernel.org
Subject: Re: Question about sys32_ioctl()
Date: Fri, 02 Apr 1999 15:45:59 +0000 [thread overview]
Message-ID: <marc-linux-ultrasparc-92306842128997@msgid-missing> (raw)
In-Reply-To: <marc-linux-ultrasparc-92306770528448@msgid-missing>
Date: Fri, 2 Apr 1999 17:35:54 +0200
From: Thierry Lafage <lafage@irisa.fr>
The sys32_ioctl() code contains things I really do not understand,
but since I applied the modification I propose below, I would like
to know if it is a bad thing for the kernel stability and/or
mechanisms.
I might put this in, but I really don't think I will because the core
problem is that this will let through ioctl's which need 32bit-->64bit
translation on their arguments and we'll have a hard time finding them
with the change in there which you propose.
Your driver may be OK, but other people's will surely not.
So just get your driver merged into the kernel, and then I'll know
about your ioctl's and can add them explicitly to the sys32_ioctl()
switch statement and this whole problem is solved.
Later,
David S. Miller
davem@redhat.com
prev parent reply other threads:[~1999-04-02 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-02 15:35 Question about sys32_ioctl() Thierry Lafage
1999-04-02 15:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ultrasparc-92306842128997@msgid-missing \
--to=davem@twiddle.net \
--cc=ultralinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.