From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 148682E647; Thu, 25 Apr 2024 10:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714040070; cv=none; b=F6vtE3azVk3DCO6ojz1RlM+hkL0VT2m2jYmzX2xLgaYHKl3ZZMRkEuzNmLryeH5+ftkTBhLzNfC/J7xiySeJcIoiyPZ+fMOnVUbVD/M+AuzQkmgQ7d635GmGdvnoLaaq71G/RdiVk8baAIHw4/KN2hrqoCjdECLQBu+ah8BNToo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714040070; c=relaxed/simple; bh=yzEXhICXLlf+DKeiLzF5a0M6Y4JEBguOjBtSKPO2DvY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=e+H7IeZ0z3NaceHEd9s+6TQFyclw9QzRuK+zZa/2HaL6HiQwUj9LZuZ81rhPznnoPQfuy4VRVUdEH/S0PpcOjeVwuwnwOhOv2MCJkutBHIg/yrRL/NMwI2mLu6gc7wEscE1agAQJQKFkPHaQRPVvkiclquml2ehTW4ikZvO4ri8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nnmu7iQh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nnmu7iQh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 507CEC113CC; Thu, 25 Apr 2024 10:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714040069; bh=yzEXhICXLlf+DKeiLzF5a0M6Y4JEBguOjBtSKPO2DvY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nnmu7iQhIvbXI1vZWEhJwaUmzbMwcLal9wtRhydM7LjPI0yQbA+l1eqYFzsRZlSyN epdEMYSzfyxkiLiuTSy53EeEjRNcCSyuukvf+4Pu1dqwc1VXT/okoTX8wLS4JQyAFs EtdDoFDtzh95YvQ+ZpaQJxm9FVJzpgOQdEg5U9dAZCPA2SgjeB1JYl/fWe8IdNxQ9y MDKrqtrFINEHzfTkCw47EPx9Y8eI2XiniH32KQtUgEvCsUUP0lgr+tCdMRfxDcRBVJ /+4X+HSFSn9G1ZL4LFhKZuJb7qee68aBz9kZMUZHaEa2dYPIl0xkLc/ALxjI1mwqmU sSl0kAh9ryGzQ== From: Puranjay Mohan To: Andrii Nakryiko Cc: Catalin Marinas , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Zi Shen Lim , Xu Kuohai , Florent Revest , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v2 2/2] bpf, arm64: inline bpf_get_smp_processor_id() helper In-Reply-To: References: <20240424173550.16359-1-puranjay@kernel.org> <20240424173550.16359-3-puranjay@kernel.org> Date: Thu, 25 Apr 2024 10:14:26 +0000 Message-ID: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andrii Nakryiko writes: > On Wed, Apr 24, 2024 at 10:36=E2=80=AFAM Puranjay Mohan wrote: >> >> As ARM64 JIT now implements BPF_MOV64_PERCPU_REG instruction, inline >> bpf_get_smp_processor_id(). >> >> ARM64 uses the per-cpu variable cpu_number to store the cpu id. >> >> Here is how the BPF and ARM64 JITed assembly changes after this commit: >> >> BPF >> =3D=3D=3D=3D=3D >> BEFORE AFTER >> -------- ------- >> >> int cpu =3D bpf_get_smp_processor_id(); int cpu =3D bpf_get_sm= p_processor_id(); >> (85) call bpf_get_smp_processor_id#229032 (18) r0 =3D 0xffff800082= 072008 >> (bf) r0 =3D r0 > > nit: hmm, you are probably using a bit outdated bpftool, it should be > emitted as: > > (bf) r0 =3D &(void __percpu *)(r0) Yes, I was using the bpftool shipped with the distro. I tried it again with the latest bpftool and it emitted this as expected. > >> (61) r0 =3D *(u32 *)(r0 = +0) >> >> ARM64 JIT >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> BEFORE AFTER >> -------- ------- >> >> int cpu =3D bpf_get_smp_processor_id(); int cpu =3D bpf_get_smp_pro= cessor_id(); >> mov x10, #0xfffffffffffff4d0 mov x7, #0xffff8000ffffff= ff >> movk x10, #0x802b, lsl #16 movk x7, #0x8207, lsl #16 >> movk x10, #0x8000, lsl #32 movk x7, #0x2008 >> blr x10 mrs x10, tpidr_el1 >> add x7, x0, #0x0 add x7, x7, x10 >> ldr w7, [x7] >> >> Performance improvement using benchmark[1] >> >> BEFORE AFTER >> -------- ------- >> >> glob-arr-inc : 23.817 =C2=B1 0.019M/s glob-arr-inc : 24.631= =C2=B1 0.027M/s >> arr-inc : 23.253 =C2=B1 0.019M/s arr-inc : 23.742= =C2=B1 0.023M/s >> hash-inc : 12.258 =C2=B1 0.010M/s hash-inc : 12.625= =C2=B1 0.004M/s >> >> [1] https://github.com/anakryiko/linux/commit/8dec900975ef >> >> Signed-off-by: Puranjay Mohan >> --- >> kernel/bpf/verifier.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> > > Besides the nits, lgtm. > > Acked-by: Andrii Nakryiko > >> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c >> index 9715c88cc025..3373be261889 100644 >> --- a/kernel/bpf/verifier.c >> +++ b/kernel/bpf/verifier.c >> @@ -20205,7 +20205,7 @@ static int do_misc_fixups(struct bpf_verifier_en= v *env) >> goto next_insn; >> } >> >> -#ifdef CONFIG_X86_64 >> +#if defined(CONFIG_X86_64) || defined(CONFIG_ARM64) > > I think you can drop this, we are protected by > bpf_jit_supports_percpu_insn() check and newly added inner #if/#elif > checks? If I remove this and later add support of percpu_insn on RISCV without inlining bpf_get_smp_processor_id() then it will cause problems here right? because then the last 5-6 lines inside this if(){} will be executed for RISCV. > >> /* Implement bpf_get_smp_processor_id() inline. */ >> if (insn->imm =3D=3D BPF_FUNC_get_smp_processor_id && >> prog->jit_requested && bpf_jit_supports_percpu_insn(= )) { >> @@ -20214,11 +20214,20 @@ static int do_misc_fixups(struct bpf_verifier_= env *env) >> * changed in some incompatible and hard to supp= ort >> * way, it's fine to back out this inlining logic >> */ >> +#if defined(CONFIG_X86_64) >> insn_buf[0] =3D BPF_MOV32_IMM(BPF_REG_0, (u32)(u= nsigned long)&pcpu_hot.cpu_number); >> insn_buf[1] =3D BPF_MOV64_PERCPU_REG(BPF_REG_0, = BPF_REG_0); >> insn_buf[2] =3D BPF_LDX_MEM(BPF_W, BPF_REG_0, BP= F_REG_0, 0); >> cnt =3D 3; >> +#elif defined(CONFIG_ARM64) >> + struct bpf_insn cpu_number_addr[2] =3D { BPF_LD_= IMM64(BPF_REG_0, (u64)&cpu_number) }; >> > > this &cpu_number offset is not guaranteed to be within 4GB on arm64? Unfortunately, the per-cpu section is not placed in the first 4GB and therefore the per-cpu pointers are not 32-bit on ARM64. > >> + insn_buf[0] =3D cpu_number_addr[0]; >> + insn_buf[1] =3D cpu_number_addr[1]; >> + insn_buf[2] =3D BPF_MOV64_PERCPU_REG(BPF_REG_0, = BPF_REG_0); >> + insn_buf[3] =3D BPF_LDX_MEM(BPF_W, BPF_REG_0, BP= F_REG_0, 0); >> + cnt =3D 4; >> +#endif >> new_prog =3D bpf_patch_insn_data(env, i + delta,= insn_buf, cnt); >> if (!new_prog) >> return -ENOMEM; >> -- >> 2.40.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E419C4345F for ; Thu, 25 Apr 2024 10:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X1chf8L3KoYEwg9ER0oX8gvRFWi2akUZ/fTqX1mRozg=; b=f9IRBCY9M597zz Pl7D83CL2f6qq3Y86wloJIKsk84KS0Q3VnCexS55FI+Z3oB1B9ZDUf8BNNiZIU3zRiJlG2blmWNum qEWVUfMzi7WjPZIqkWyyV+Xy9V3PurVuVSIry6bWoUyTujpZ/3fjQquKM7RpInL3feh69spQyvWkS Js163khiMVip6txZtSo6WzvdwdbC4P02jvf6QfVl2eYoho44W4JvvA0MtqcIaJxmaugRPg0dOW82X 7iH162qQAteSB18ltrH4dXoLujrQOYcFJw/kJGWoHA4PlSPpjlQXP97X1c4dsBjrsgMlRxugN4TVn /JSZPFSSoWsGyYbLoAuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzw7f-00000007mik-3D7H; Thu, 25 Apr 2024 10:14:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzw7c-00000007mhl-3C3W for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 10:14:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 83010CE19AC; Thu, 25 Apr 2024 10:14:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 507CEC113CC; Thu, 25 Apr 2024 10:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714040069; bh=yzEXhICXLlf+DKeiLzF5a0M6Y4JEBguOjBtSKPO2DvY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nnmu7iQhIvbXI1vZWEhJwaUmzbMwcLal9wtRhydM7LjPI0yQbA+l1eqYFzsRZlSyN epdEMYSzfyxkiLiuTSy53EeEjRNcCSyuukvf+4Pu1dqwc1VXT/okoTX8wLS4JQyAFs EtdDoFDtzh95YvQ+ZpaQJxm9FVJzpgOQdEg5U9dAZCPA2SgjeB1JYl/fWe8IdNxQ9y MDKrqtrFINEHzfTkCw47EPx9Y8eI2XiniH32KQtUgEvCsUUP0lgr+tCdMRfxDcRBVJ /+4X+HSFSn9G1ZL4LFhKZuJb7qee68aBz9kZMUZHaEa2dYPIl0xkLc/ALxjI1mwqmU sSl0kAh9ryGzQ== From: Puranjay Mohan To: Andrii Nakryiko Cc: Catalin Marinas , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Zi Shen Lim , Xu Kuohai , Florent Revest , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v2 2/2] bpf, arm64: inline bpf_get_smp_processor_id() helper In-Reply-To: References: <20240424173550.16359-1-puranjay@kernel.org> <20240424173550.16359-3-puranjay@kernel.org> Date: Thu, 25 Apr 2024 10:14:26 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_031433_240776_ED2D2D7C X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW5kcmlpIE5ha3J5aWtvIDxhbmRyaWkubmFrcnlpa29AZ21haWwuY29tPiB3cml0ZXM6Cgo+IE9u IFdlZCwgQXByIDI0LCAyMDI0IGF0IDEwOjM24oCvQU0gUHVyYW5qYXkgTW9oYW4gPHB1cmFuamF5 QGtlcm5lbC5vcmc+IHdyb3RlOgo+Pgo+PiBBcyBBUk02NCBKSVQgbm93IGltcGxlbWVudHMgQlBG X01PVjY0X1BFUkNQVV9SRUcgaW5zdHJ1Y3Rpb24sIGlubGluZQo+PiBicGZfZ2V0X3NtcF9wcm9j ZXNzb3JfaWQoKS4KPj4KPj4gQVJNNjQgdXNlcyB0aGUgcGVyLWNwdSB2YXJpYWJsZSBjcHVfbnVt YmVyIHRvIHN0b3JlIHRoZSBjcHUgaWQuCj4+Cj4+IEhlcmUgaXMgaG93IHRoZSBCUEYgYW5kIEFS TTY0IEpJVGVkIGFzc2VtYmx5IGNoYW5nZXMgYWZ0ZXIgdGhpcyBjb21taXQ6Cj4+Cj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQlBGCj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICA9PT09PQo+PiAgICAgICAgICAgICAgIEJFRk9SRSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEFGVEVSCj4+ICAgICAgICAgICAg ICAtLS0tLS0tLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLS0tLS0tCj4+ Cj4+IGludCBjcHUgPSBicGZfZ2V0X3NtcF9wcm9jZXNzb3JfaWQoKTsgICAgICAgICAgIGludCBj cHUgPSBicGZfZ2V0X3NtcF9wcm9jZXNzb3JfaWQoKTsKPj4gKDg1KSBjYWxsIGJwZl9nZXRfc21w X3Byb2Nlc3Nvcl9pZCMyMjkwMzIgICAgICAgKDE4KSByMCA9IDB4ZmZmZjgwMDA4MjA3MjAwOAo+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYmYpIHIw ID0gcjAKPgo+IG5pdDogaG1tLCB5b3UgYXJlIHByb2JhYmx5IHVzaW5nIGEgYml0IG91dGRhdGVk IGJwZnRvb2wsIGl0IHNob3VsZCBiZQo+IGVtaXR0ZWQgYXM6Cj4KPiAoYmYpIHIwID0gJih2b2lk IF9fcGVyY3B1ICopKHIwKQoKWWVzLCBJIHdhcyB1c2luZyB0aGUgYnBmdG9vbCBzaGlwcGVkIHdp dGggdGhlIGRpc3Ryby4gSSB0cmllZCBpdCBhZ2Fpbgp3aXRoIHRoZSBsYXRlc3QgYnBmdG9vbCBh bmQgaXQgZW1pdHRlZCB0aGlzIGFzIGV4cGVjdGVkLgoKPgo+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoNjEpIHIwID0gKih1MzIgKikocjAgKzApCj4+ Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQVJNNjQgSklUCj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA9PT09PT09PT09PQo+Pgo+PiAgICAg ICAgICAgICAgIEJFRk9SRSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEFG VEVSCj4+ICAgICAgICAgICAgICAtLS0tLS0tLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAtLS0tLS0tCj4+Cj4+IGludCBjcHUgPSBicGZfZ2V0X3NtcF9wcm9jZXNzb3JfaWQo KTsgICAgICBpbnQgY3B1ID0gYnBmX2dldF9zbXBfcHJvY2Vzc29yX2lkKCk7Cj4+IG1vdiAgICAg eDEwLCAjMHhmZmZmZmZmZmZmZmZmNGQwICAgICAgICAgICBtb3YgICAgIHg3LCAjMHhmZmZmODAw MGZmZmZmZmZmCj4+IG1vdmsgICAgeDEwLCAjMHg4MDJiLCBsc2wgIzE2ICAgICAgICAgICAgICBt b3ZrICAgIHg3LCAjMHg4MjA3LCBsc2wgIzE2Cj4+IG1vdmsgICAgeDEwLCAjMHg4MDAwLCBsc2wg IzMyICAgICAgICAgICAgICBtb3ZrICAgIHg3LCAjMHgyMDA4Cj4+IGJsciAgICAgeDEwICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBtcnMgICAgIHgxMCwgdHBpZHJfZWwxCj4+IGFkZCAg ICAgeDcsIHgwLCAjMHgwICAgICAgICAgICAgICAgICAgICAgICBhZGQgICAgIHg3LCB4NywgeDEw Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZHIgICAgIHc3 LCBbeDddCj4+Cj4+IFBlcmZvcm1hbmNlIGltcHJvdmVtZW50IHVzaW5nIGJlbmNobWFya1sxXQo+ Pgo+PiAgICAgICAgICAgICAgQkVGT1JFICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgQUZURVIKPj4gICAgICAgICAgICAgLS0tLS0tLS0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgLS0tLS0tLQo+Pgo+PiBnbG9iLWFyci1pbmMgICA6ICAgMjMuODE3IMKx IDAuMDE5TS9zICAgICAgZ2xvYi1hcnItaW5jICAgOiAgIDI0LjYzMSDCsSAwLjAyN00vcwo+PiBh cnItaW5jICAgICAgICA6ICAgMjMuMjUzIMKxIDAuMDE5TS9zICAgICAgYXJyLWluYyAgICAgICAg OiAgIDIzLjc0MiDCsSAwLjAyM00vcwo+PiBoYXNoLWluYyAgICAgICA6ICAgMTIuMjU4IMKxIDAu MDEwTS9zICAgICAgaGFzaC1pbmMgICAgICAgOiAgIDEyLjYyNSDCsSAwLjAwNE0vcwo+Pgo+PiBb MV0gaHR0cHM6Ly9naXRodWIuY29tL2FuYWtyeWlrby9saW51eC9jb21taXQvOGRlYzkwMDk3NWVm Cj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFB1cmFuamF5IE1vaGFuIDxwdXJhbmpheUBrZXJuZWwub3Jn Pgo+PiAtLS0KPj4gIGtlcm5lbC9icGYvdmVyaWZpZXIuYyB8IDExICsrKysrKysrKystCj4+ICAx IGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pgo+Cj4gQmVz aWRlcyB0aGUgbml0cywgbGd0bS4KPgo+IEFja2VkLWJ5OiBBbmRyaWkgTmFrcnlpa28gPGFuZHJp aUBrZXJuZWwub3JnPgo+Cj4+IGRpZmYgLS1naXQgYS9rZXJuZWwvYnBmL3ZlcmlmaWVyLmMgYi9r ZXJuZWwvYnBmL3ZlcmlmaWVyLmMKPj4gaW5kZXggOTcxNWM4OGNjMDI1Li4zMzczYmUyNjE4ODkg MTAwNjQ0Cj4+IC0tLSBhL2tlcm5lbC9icGYvdmVyaWZpZXIuYwo+PiArKysgYi9rZXJuZWwvYnBm L3ZlcmlmaWVyLmMKPj4gQEAgLTIwMjA1LDcgKzIwMjA1LDcgQEAgc3RhdGljIGludCBkb19taXNj X2ZpeHVwcyhzdHJ1Y3QgYnBmX3ZlcmlmaWVyX2VudiAqZW52KQo+PiAgICAgICAgICAgICAgICAg ICAgICAgICBnb3RvIG5leHRfaW5zbjsKPj4gICAgICAgICAgICAgICAgIH0KPj4KPj4gLSNpZmRl ZiBDT05GSUdfWDg2XzY0Cj4+ICsjaWYgZGVmaW5lZChDT05GSUdfWDg2XzY0KSB8fCBkZWZpbmVk KENPTkZJR19BUk02NCkKPgo+IEkgdGhpbmsgeW91IGNhbiBkcm9wIHRoaXMsIHdlIGFyZSBwcm90 ZWN0ZWQgYnkKPiBicGZfaml0X3N1cHBvcnRzX3BlcmNwdV9pbnNuKCkgY2hlY2sgYW5kIG5ld2x5 IGFkZGVkIGlubmVyICNpZi8jZWxpZgo+IGNoZWNrcz8KCklmIEkgcmVtb3ZlIHRoaXMgYW5kIGxh dGVyIGFkZCBzdXBwb3J0IG9mIHBlcmNwdV9pbnNuIG9uIFJJU0NWIHdpdGhvdXQKaW5saW5pbmcg YnBmX2dldF9zbXBfcHJvY2Vzc29yX2lkKCkgdGhlbiBpdCB3aWxsIGNhdXNlIHByb2JsZW1zIGhl cmUKcmlnaHQ/IGJlY2F1c2UgdGhlbiB0aGUgbGFzdCA1LTYgbGluZXMgaW5zaWRlIHRoaXMgaWYo KXt9IHdpbGwgYmUKZXhlY3V0ZWQgZm9yIFJJU0NWLgoKPgo+PiAgICAgICAgICAgICAgICAgLyog SW1wbGVtZW50IGJwZl9nZXRfc21wX3Byb2Nlc3Nvcl9pZCgpIGlubGluZS4gKi8KPj4gICAgICAg ICAgICAgICAgIGlmIChpbnNuLT5pbW0gPT0gQlBGX0ZVTkNfZ2V0X3NtcF9wcm9jZXNzb3JfaWQg JiYKPj4gICAgICAgICAgICAgICAgICAgICBwcm9nLT5qaXRfcmVxdWVzdGVkICYmIGJwZl9qaXRf c3VwcG9ydHNfcGVyY3B1X2luc24oKSkgewo+PiBAQCAtMjAyMTQsMTEgKzIwMjE0LDIwIEBAIHN0 YXRpYyBpbnQgZG9fbWlzY19maXh1cHMoc3RydWN0IGJwZl92ZXJpZmllcl9lbnYgKmVudikKPj4g ICAgICAgICAgICAgICAgICAgICAgICAgICogY2hhbmdlZCBpbiBzb21lIGluY29tcGF0aWJsZSBh bmQgaGFyZCB0byBzdXBwb3J0Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAqIHdheSwgaXQn cyBmaW5lIHRvIGJhY2sgb3V0IHRoaXMgaW5saW5pbmcgbG9naWMKPj4gICAgICAgICAgICAgICAg ICAgICAgICAgICovCj4+ICsjaWYgZGVmaW5lZChDT05GSUdfWDg2XzY0KQo+PiAgICAgICAgICAg ICAgICAgICAgICAgICBpbnNuX2J1ZlswXSA9IEJQRl9NT1YzMl9JTU0oQlBGX1JFR18wLCAodTMy KSh1bnNpZ25lZCBsb25nKSZwY3B1X2hvdC5jcHVfbnVtYmVyKTsKPj4gICAgICAgICAgICAgICAg ICAgICAgICAgaW5zbl9idWZbMV0gPSBCUEZfTU9WNjRfUEVSQ1BVX1JFRyhCUEZfUkVHXzAsIEJQ Rl9SRUdfMCk7Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgIGluc25fYnVmWzJdID0gQlBGX0xE WF9NRU0oQlBGX1csIEJQRl9SRUdfMCwgQlBGX1JFR18wLCAwKTsKPj4gICAgICAgICAgICAgICAg ICAgICAgICAgY250ID0gMzsKPj4gKyNlbGlmIGRlZmluZWQoQ09ORklHX0FSTTY0KQo+PiArICAg ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgYnBmX2luc24gY3B1X251bWJlcl9hZGRyWzJdID0g eyBCUEZfTERfSU1NNjQoQlBGX1JFR18wLCAodTY0KSZjcHVfbnVtYmVyKSB9Owo+Pgo+Cj4gdGhp cyAmY3B1X251bWJlciBvZmZzZXQgaXMgbm90IGd1YXJhbnRlZWQgdG8gYmUgd2l0aGluIDRHQiBv biBhcm02ND8KClVuZm9ydHVuYXRlbHksIHRoZSBwZXItY3B1IHNlY3Rpb24gaXMgbm90IHBsYWNl ZCBpbiB0aGUgZmlyc3QgNEdCIGFuZAp0aGVyZWZvcmUgdGhlIHBlci1jcHUgcG9pbnRlcnMgYXJl IG5vdCAzMi1iaXQgb24gQVJNNjQuCgo+Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGluc25f YnVmWzBdID0gY3B1X251bWJlcl9hZGRyWzBdOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBp bnNuX2J1ZlsxXSA9IGNwdV9udW1iZXJfYWRkclsxXTsKPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgaW5zbl9idWZbMl0gPSBCUEZfTU9WNjRfUEVSQ1BVX1JFRyhCUEZfUkVHXzAsIEJQRl9SRUdf MCk7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGluc25fYnVmWzNdID0gQlBGX0xEWF9NRU0o QlBGX1csIEJQRl9SRUdfMCwgQlBGX1JFR18wLCAwKTsKPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgY250ID0gNDsKPj4gKyNlbmRpZgo+PiAgICAgICAgICAgICAgICAgICAgICAgICBuZXdfcHJv ZyA9IGJwZl9wYXRjaF9pbnNuX2RhdGEoZW52LCBpICsgZGVsdGEsIGluc25fYnVmLCBjbnQpOwo+ PiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIW5ld19wcm9nKQo+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+PiAtLQo+PiAyLjQwLjEKPj4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK