From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] vboxguestdrivers: import recipe from meta-luneos
Date: Tue, 03 Mar 2015 10:19:32 +0100 [thread overview]
Message-ID: <md3ub4$594$1@ger.gmane.org> (raw)
In-Reply-To: <20150302102611.GY2309@jama>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Jansa schreef op 02-03-15 om 11:26:
> On Mon, Mar 02, 2015 at 11:22:30AM +0100, Koen Kooi wrote: Martin Jansa
> schreef op 02-03-15 om 09:02:
>>>> * useful to run our qemu* builds inside VirtualBox
>>>>
>>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> ---
>>>> .../vboxguestdrivers/Makefile.utils | 43
>>>> ++++++++++++++ .../vboxguestdrivers/vboxguestdrivers_4.3.22.bb |
>>>> 65 ++++++++++++++++++++++
>
>>>> +PACKAGES += "kernel-module-vboxguest kernel-module-vboxsf
>>>> kernel-module-vboxvideo" +RDEPENDS_${PN} +=
>>>> "kernel-module-vboxguest kernel-module-vboxsf
>>>> kernel-module-vboxvideo"
>
> Please don't ever RDEPEND on kernel modules, even when the recipe will
> build them, it sets a bad precedent.
>
>> I think it makes sense in this case.. nobody will ever include them in
>> kernel image and vboxguestdrivers utils don't make much sense without
>> the modules installed.
I agree completely with that, my objection is setting a bad precedent that
people will copy/paste into other recipes.
I see v2 has RRECOMMENDS, thank you for changing it.
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFU9XykMkyGM64RGpERAtp/AJ9/M6P16FGCn/EvTXEWCygoon+NHACfWKPA
j0bXmjsmVkWxKsJ+e5Ulaog=
=H4No
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2015-03-03 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 8:02 [meta-oe][PATCH] vboxguestdrivers: import recipe from meta-luneos Martin Jansa
2015-03-02 10:22 ` Koen Kooi
2015-03-02 10:26 ` Martin Jansa
2015-03-02 10:55 ` Florian Boor
2015-03-02 11:33 ` Martin Jansa
2015-03-03 9:19 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='md3ub4$594$1@ger.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.