From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Aur=C3=A9lien?= Aptel Subject: Re: [PATCH] cifs_get_root shouldn't use path with tree name Date: Wed, 14 Dec 2016 10:55:45 +0100 Message-ID: References: <1473260003-5271-1-git-send-email-sprabhu@redhat.com> <1481632417.2630.13.camel@redhat.com> <1481634390.2630.16.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT To: Jeff Layton , Sachin Prabhu , linux-cifs Return-path: In-Reply-To: <1481634390.2630.16.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Jeff Layton writes: > On Tue, 2016-12-13 at 07:33 -0500, Jeff Layton wrote: > I think is this a reasonable fix for now. That said, this whole Rube > Goldberg contraption could really use a serious re-think, IMO... Indeed. I find cifs_mount() in particular really hard to follow. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)