Re: [PATCH] cifs_get_root shouldn't use path with tree name

["Aurélien Aptel" <aaptel-IBi9RG/b67k@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]


Hi Sachin,

As you said, patch is similar to what I proposed few month ago. There's
only one thing that bothers me. cifs_build_path_to_root() has this bit
before the DFS test:

	/* if no prefix path, simply set path to the root of share to "" */
	if (pplen == 0) {
		full_path = kzalloc(1, GFP_KERNEL);
		return full_path;
	}


I think it should be dropped. It was already inconsistent because if the
share was in a DFS without a prepath it would have returned an empty
string instead of a path with the tree name prefix.

I can send a patch after yours to correct that you think it should be in
a separate commit.

Cheers,

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]