From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.nue.novell.com ([195.135.221.5]:51854 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1039605AbdDUNgj (ORCPT ); Fri, 21 Apr 2017 09:36:39 -0400 From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH 1/1] fs/inode.c: spelling in inode_owner_or_capable doc In-Reply-To: <20170421122138.GD27790@bombadil.infradead.org> References: <20170421113758.16274-1-aaptel@suse.com> <20170421122138.GD27790@bombadil.infradead.org> Date: Fri, 21 Apr 2017 15:36:37 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Matthew Wilcox writes: > This is wrong. "if the current task has either FOO or owns the file". > It's also unnecessarily complex. Try this: > > * Return true if the current task owns the file or has CAP_FOWNER in a > * namespace with the inode owner uid mapped > > ("either" in this context would imply exclusive-or, which isn't the intended > meaning). Sounds good, I'll send an updated patch. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)