Re: [PATCH] Fix regression which breaks DFS mounting

["Aurélien Aptel" <aaptel-IBi9RG/b67k@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

Hi Sachin,

Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> This is hit in Netapp because it returns SMB_SHARE_IS_IN_DFS even after
> the DFS node is resolved and the node returned doesn't contain a DFS
> share. Other servers(tested with MS Win2012 R2) do not and hence do not
> face this problem. A workaround for Netapp servers is to mount with the
> nodfs flag.

The issue I'm describing is happening on samba servers. Server A has 2
DFS links to server B. First link is pointing the the root of a share,
second link is pointing to a subdir of the same share. mounting A share
and trying to ls or cd in these links result in both pointing to the
root of the share B.

> I have a patch similar to your second variant which we have
> successfully tested in our lab and is currently undergoing user
> testing. I'll post it separately as soon as we have the results for
> that.
>
> In my opinion, the patch at the head of the thread here is not related
> to this problem and should go in ASAP to fix a regression which affects
> all DFS mounts.

Agreed. I can confirm that this patch lets me mount
//SERVER/share/dfs-main where dfs-main is a DFS link. I was previously
getting:

mount error(22): Invalid argument

Tested-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]