From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Aur=C3=A9lien?= Aptel Subject: Re: [PATCH] cifs_get_root shouldn't use path with tree name Date: Thu, 06 Oct 2016 14:15:36 +0200 Message-ID: References: <1473260003-5271-1-git-send-email-sprabhu@redhat.com> <1473698409.29354.3.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT To: Sachin Prabhu , linux-cifs Return-path: In-Reply-To: <1473698409.29354.3.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: What is the status on this? If we explicitely ask for a tree name prefix via the new parameter, we should always get it. It should not return an empty string if there is no prepath. Sachin Prabhu writes: > I suspect that is because the root of the share cannot be a DFS mount. > Maybe Steve can confirm it. So that means we can safely remove that early return, IIUC. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)