From: "Aurélien Aptel" <aaptel-IBi9RG/b67k@public.gmane.org>
To: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 1/1] fs/cifs/dir.c: use correct path separators
Date: Sat, 17 Sep 2016 09:54:38 +0200 [thread overview]
Message-ID: <mpswpibklkx.fsf@suse.com> (raw)
In-Reply-To: <1473705389.29354.20.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> We have an inline helper convert_delimiter() which already does this.
> The block for dfsplen also seems to repeat the code.
Correct except for a small detail: the inline helper does the conversion
until the end of the string. Here we need to stop in the middle.
> Can we use the helper for the complete patch instead when the
> full_path variable is available?
We do not want to mess with unix path that might contain a valid
backslash inside a path component.
> I think the code here for copying the treename and the prefixpath name
> can also be cleaned to make it easier to read ie. move the treeName
> copy before we copy over the prefix path.
Agreed. Thanks for the feedback, Sachin.
I'll send an updated patch for review.
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2016-09-17 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 13:45 [PATCH v1 1/1] fs/cifs/dir.c: use correct path separators Aurelien Aptel
[not found] ` <1473255952-27579-1-git-send-email-aaptel-IBi9RG/b67k@public.gmane.org>
2016-09-12 18:36 ` Sachin Prabhu
[not found] ` <1473705389.29354.20.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-17 7:54 ` Aurélien Aptel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpswpibklkx.fsf@suse.com \
--to=aaptel-ibi9rg/b67k@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.