All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Don Brace <don.brace@pmcs.com>,
	linux-kernel@vger.kernel.org, iss_storagedev@hp.com,
	storagedev@pmcs.com, linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>
Date: Mon, 03 Aug 2015 09:20:20 +0200	[thread overview]
Message-ID: <mqd614w6dor.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <1438547113.29569.5.camel@perches.com> (Joe Perches's message of "Sun, 02 Aug 2015 13:25:13 -0700")

Joe Perches <joe@perches.com> writes:

> Correct misuse of 0x%d in logging messages.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/block/DAC960.c | 4 ++--
>  drivers/block/cciss.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
> index 811e11c..d9b32f2 100644
> --- a/drivers/block/DAC960.c
> +++ b/drivers/block/DAC960.c
> @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
>         case DAC960_PD_Controller:
>           if (!request_region(Controller->IO_Address, 0x80,
>                               Controller->FullModelName)) {
> -               DAC960_Error("IO port 0x%d busy for Controller at\n",
> +               DAC960_Error("IO port 0x%x busy for Controller at\n",
>                              Controller, Controller->IO_Address);
>                 goto Failure;
>           }
> @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
>         case DAC960_P_Controller:
>           if (!request_region(Controller->IO_Address, 0x80,
>                               Controller->FullModelName)){
> -               DAC960_Error("IO port 0x%d busy for Controller at\n",
> +               DAC960_Error("IO port 0x%x busy for Controller at\n",
>                              Controller, Controller->IO_Address);
>                 goto Failure;
>           }
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 0422c47..2758982 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h)
>                readl(&(tb->HostWrite.CoalIntDelay)));
>         dev_dbg(&h->pdev->dev, "   Coalesce Interrupt Count = 0x%x\n",
>                readl(&(tb->HostWrite.CoalIntCount)));
> -       dev_dbg(&h->pdev->dev, "   Max outstanding commands = 0x%d\n",
> +       dev_dbg(&h->pdev->dev, "   Max outstanding commands = 0x%x\n",
>                readl(&(tb->CmdsOutMax)));
>         dev_dbg(&h->pdev->dev, "   Bus Types = 0x%x\n",
>                 readl(&(tb->BusTypes)));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                           Storage
jthumshirn@suse.de                                 +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600  D0D0 0393 969D 2D76 0850

  reply	other threads:[~2015-08-03  7:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-02 20:25 [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> Joe Perches
2015-08-03  7:20 ` Johannes Thumshirn [this message]
2015-08-03  7:25 ` yalin wang
2015-08-03  7:25   ` yalin wang
2015-08-03  8:03   ` Joe Perches
2015-08-03  8:56     ` yalin wang
2015-08-04  2:19       ` yalin wang
2015-08-04  2:27         ` Joe Perches
2015-08-04  4:04           ` yalin wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mqd614w6dor.fsf@c203.arch.suse.de \
    --to=jthumshirn@suse.de \
    --cc=don.brace@pmcs.com \
    --cc=iss_storagedev@hp.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=storagedev@pmcs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.