From: Andreas Schwab <schwab@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tobias Schramm <t.schramm@manjaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: mmc_spi: add spi:mmc-spi-slot alias
Date: Thu, 22 Jul 2021 14:37:43 +0200 [thread overview]
Message-ID: <mvm4kcm5xt4.fsf@suse.de> (raw)
In-Reply-To: <mvm8s1y5zbz.fsf@suse.de> (Andreas Schwab's message of "Thu, 22 Jul 2021 14:04:48 +0200")
On Jul 22 2021, Andreas Schwab wrote:
> On Jul 22 2021, Andy Shevchenko wrote:
>
>> Compare the code of
>> https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L649
>> vs.
>> https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L56
>>
>> and
>>
>> https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L139
>> vs.
>> https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L361
>
> Thanks, I think I now know how to fix it correctly.
In fact, the correct fix has already been installed in commit
3ce6c9e2617e ("spi: add of_device_uevent_modalias support"), which is
part of -rc1, just incomplete, which explains the inconsistency above.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2021-07-22 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 13:26 [PATCH] mmc: mmc_spi: add spi:mmc-spi-slot alias Andreas Schwab
2021-07-21 14:33 ` Andy Shevchenko
2021-07-21 14:37 ` Andreas Schwab
2021-07-21 15:03 ` Andy Shevchenko
2021-07-21 15:15 ` Andreas Schwab
2021-07-21 15:45 ` Andy Shevchenko
2021-07-21 16:05 ` Andreas Schwab
2021-07-21 17:05 ` Andy Shevchenko
2021-07-21 19:53 ` Andreas Schwab
2021-07-21 20:05 ` Andy Shevchenko
2021-07-22 10:03 ` Andreas Schwab
2021-07-22 10:28 ` Andy Shevchenko
2021-07-22 10:36 ` Andy Shevchenko
2021-07-22 12:04 ` Andreas Schwab
2021-07-22 12:37 ` Andreas Schwab [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-08 14:11 Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm4kcm5xt4.fsf@suse.de \
--to=schwab@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=t.schramm@manjaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.