From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRln-00011a-3O for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPRli-0000bB-4K for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:52:23 -0400 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:43577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRlh-0000ZW-UQ for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:52:18 -0400 From: Andreas Schwab References: <1439151229-27747-1-git-send-email-laurent@vivier.eu> <1439151229-27747-6-git-send-email-laurent@vivier.eu> <55CAC68E.60601@twiddle.net> <55CB077B.6050702@vivier.eu> Date: Wed, 12 Aug 2015 10:52:13 +0200 In-Reply-To: <55CB077B.6050702@vivier.eu> (Laurent Vivier's message of "Wed, 12 Aug 2015 10:44:43 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.5 05/30] m68k: define operand sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, gerg@uclinux.org, qemu-devel@nongnu.org, Richard Henderson Laurent Vivier writes: > Le 12/08/2015 06:07, Richard Henderson a =C3=A9crit : >> Is there a reason you've skipped the 0 value when adding the new value= s? > > I think there is no reason, but if I change the value I have to update > abdc_mem, sbcd_mem instructions as they use it as an > incrementer/decrementer. I agree, it's a strange idea. Those uses are really opsize_bytes(OS_BYTE), technically. Andreas. --=20 Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."