From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75966C43387 for ; Thu, 10 Jan 2019 15:26:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 441DD214C6 for ; Thu, 10 Jan 2019 15:26:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hL1CPoq7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 441DD214C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=um5pb7X1fmHZy44mT1kapL6v/efgOKRYjHZbNsc5U2k=; b=hL1CPoq7sTC9LG YuGwjHQDkRgo0faJBFwYfgn+E0sgWSR8vq6cNNtq11hJGgx7Vf+4qw7gPBIAXQQ0Ay34+HlHBZXbj mIdvdiuflBne1I8H/4cjPdhchOX1eIkHGN8G102Qi0vYhvIS9zCw++oVsrYdLtwHSkU96RESkSFT3 3b34PGCPqWiV9wtWpNkBYjABTnufE1Nfcr5fhestM2A1EDxrk/TBzoFdKHBIOnZJhkginKPv7+dbk AQJPfGx9z4MUxOiyUSKb5PFz0Wy1sNiFtMHFIhiRHBBwsa+sLtUDbF9sHmHNCZznMStyvzpWzJ8Hn 8CcDZ9Nzn4fMas2+iGBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghcES-0007Si-Dr; Thu, 10 Jan 2019 15:26:56 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghcEO-0007KP-3p for linux-riscv@lists.infradead.org; Thu, 10 Jan 2019 15:26:53 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E9BA0AF9A; Thu, 10 Jan 2019 15:26:47 +0000 (UTC) From: Andreas Schwab To: Anup Patel Subject: Re: [PATCH] tty/serial: emit CR before NL in RISC-V SBL console References: <20181204135507.3706-1-anup@brainfault.org> <20181204135507.3706-2-anup@brainfault.org> X-Yow: Why is everything made of Lycra Spandex? Date: Thu, 10 Jan 2019 16:26:46 +0100 In-Reply-To: (Anup Patel's message of "Thu, 10 Jan 2019 20:46:51 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190110_072652_306143_560DDFE5 X-CRM114-Status: UNSURE ( 7.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Albert Ou , Greg Kroah-Hartman , Palmer Dabbelt , "linux-kernel@vger.kernel.org List" , Christoph Hellwig , Atish Patra , linux-serial@vger.kernel.org, Jiri Slaby , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Jan 10 2019, Anup Patel wrote: > Instead of doing '\n' handling here, we should do it in BBL or > OpenSBI (i.e. SBI runtime firmware) otherwise all users of > SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD, > FreeRTOS, U-Boot S-mode, etc) will endup having '\n' > handling. I don't think the serial driver should do NLCR handling on its own, without being instructed by the tty layer. Since the earlycon does not have a tty layer, it needs to handle it explicitly. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH] tty/serial: emit CR before NL in RISC-V SBL console Date: Thu, 10 Jan 2019 16:26:46 +0100 Message-ID: References: <20181204135507.3706-1-anup@brainfault.org> <20181204135507.3706-2-anup@brainfault.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Anup Patel's message of "Thu, 10 Jan 2019 20:46:51 +0530") Sender: linux-kernel-owner@vger.kernel.org To: Anup Patel Cc: Greg Kroah-Hartman , Jiri Slaby , Palmer Dabbelt , Albert Ou , Atish Patra , Christoph Hellwig , Rob Herring , linux-riscv@lists.infradead.org, "linux-kernel@vger.kernel.org List" , linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Jan 10 2019, Anup Patel wrote: > Instead of doing '\n' handling here, we should do it in BBL or > OpenSBI (i.e. SBI runtime firmware) otherwise all users of > SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD, > FreeRTOS, U-Boot S-mode, etc) will endup having '\n' > handling. I don't think the serial driver should do NLCR handling on its own, without being instructed by the tty layer. Since the earlycon does not have a tty layer, it needs to handle it explicitly. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."