From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gOgg6-0007S5-4a for mharc-grub-devel@gnu.org; Mon, 19 Nov 2018 05:21:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgg1-00079b-Qq for grub-devel@gnu.org; Mon, 19 Nov 2018 05:21:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgWQ-0002Iw-HJ for grub-devel@gnu.org; Mon, 19 Nov 2018 05:11:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:46516 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOgWQ-00029G-Bj for grub-devel@gnu.org; Mon, 19 Nov 2018 05:11:14 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AA255ACD1; Mon, 19 Nov 2018 10:11:11 +0000 (UTC) From: Andreas Schwab To: Alexander Graf Cc: grub-devel@gnu.org, leif.lindholm@linaro.org, Peter Jones , Paul Walmsley , David Abdurachmanov , atish.patra@wdc.com, Michael Chang , Alistair Francis , Lukas Auer , "greentime \@ andestech . com" , "rickchen36 \@ gmail . com" , Bin Meng Subject: Re: [PATCH v3 10/10] fdt: Add device tree file type References: <20181114172739.51640-1-agraf@suse.de> <20181114172739.51640-11-agraf@suse.de> X-Yow: I had a lease on an OEDIPUS COMPLEX back in '81... Date: Mon, 19 Nov 2018 11:11:09 +0100 In-Reply-To: <20181114172739.51640-11-agraf@suse.de> (Alexander Graf's message of "Wed, 14 Nov 2018 18:27:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 10:21:13 -0000 On Nov 14 2018, Alexander Graf wrote: > diff --git a/grub-core/loader/efi/fdt.c b/grub-core/loader/efi/fdt.c > index a4c6e8036..d8ebe648e 100644 > --- a/grub-core/loader/efi/fdt.c > +++ b/grub-core/loader/efi/fdt.c > @@ -123,7 +123,7 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ ((unused)), > return GRUB_ERR_NONE; > } > > - dtb = grub_file_open (argv[0]); > + dtb = grub_file_open (argv[0], GRUB_FILE_TYPE_DEVICE_TREE); > if (!dtb) > goto out; > Looks like this has been obsoleted by commit dfb1742aab? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."