From mboxrd@z Thu Jan  1 00:00:00 1970
From: schwab@suse.de (Andreas Schwab)
Date: Thu, 25 Feb 2016 11:50:31 +0100
Subject: [RFC5 PATCH v6 00/21] ILP32 for ARM64
In-Reply-To: <20160218223506.GA7816@yury-N73SV> (Yury Norov's message of "Fri,
 19 Feb 2016 01:35:06 +0300")
References: <1452792198-10718-1-git-send-email-ynorov@caviumnetworks.com>
 <56AB3805.1040308@huawei.com> <20160129170929.GA3543@yury-N73SV>
 <56AC38F1.2030608@huawei.com> <20160218223506.GA7816@yury-N73SV>
Message-ID: <mvm8u29ukqw.fsf@hawking.suse.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Yury Norov <ynorov@caviumnetworks.com> writes:

> I have new glibc that follows new ABI:
> https://github.com/norov/glibc/tree/new-api

sysdeps/unix/sysv/linux/aarch64/ilp32/getdents64.c is wrong, struct
dirent64 is not the same as struct dirent.  The file needs to be renamed
to sysdeps/unix/sysv/linux/aarch64/ilp32/getdents.c so that __getdents64
comes from sysdeps/unix/sysv/linux/generic/getdents64.c.

sysdeps/unix/sysv/linux/aarch64/ilp32/*xstat*.c should not set errno,
INLINE_SYSCALL already does that, and returns -1 on error.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab at suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760479AbcBYKuh (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 05:50:37 -0500
Received: from mx2.suse.de ([195.135.220.15]:50117 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759412AbcBYKuf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 05:50:35 -0500
From: Andreas Schwab <schwab@suse.de>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: "Zhangjian \(Bamvor\)" <bamvor.zhangjian@huawei.com>, <arnd@arndb.de>,
        <catalin.marinas@arm.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <pinskia@gmail.com>,
        <Prasun.Kapoor@caviumnetworks.com>, <broonie@kernel.org>,
        <heiko.carstens@de.ibm.com>, <agraf@suse.de>, <klimov.linux@gmail.com>,
        <jan.dakinevich@gmail.com>, <schwidefsky@de.ibm.com>,
        <Nathan_Lynch@mentor.com>, <joseph@codesourcery.com>,
        <christoph.muellner@theobroma-systems.com>
Subject: Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64
References: <1452792198-10718-1-git-send-email-ynorov@caviumnetworks.com>
	<56AB3805.1040308@huawei.com> <20160129170929.GA3543@yury-N73SV>
	<56AC38F1.2030608@huawei.com> <20160218223506.GA7816@yury-N73SV>
X-Yow: What GOOD is a CARDBOARD suitcase ANYWAY?
Date: Thu, 25 Feb 2016 11:50:31 +0100
In-Reply-To: <20160218223506.GA7816@yury-N73SV> (Yury Norov's message of "Fri,
	19 Feb 2016 01:35:06 +0300")
Message-ID: <mvm8u29ukqw.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yury Norov <ynorov@caviumnetworks.com> writes:

> I have new glibc that follows new ABI:
> https://github.com/norov/glibc/tree/new-api

sysdeps/unix/sysv/linux/aarch64/ilp32/getdents64.c is wrong, struct
dirent64 is not the same as struct dirent.  The file needs to be renamed
to sysdeps/unix/sysv/linux/aarch64/ilp32/getdents.c so that __getdents64
comes from sysdeps/unix/sysv/linux/generic/getdents64.c.

sysdeps/unix/sysv/linux/aarch64/ilp32/*xstat*.c should not set errno,
INLINE_SYSCALL already does that, and returns -1 on error.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."