From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1ZPR48-00017H-24
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:07:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1ZPR44-00066g-SN
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:07:16 -0400
Received: from mail-out.m-online.net ([212.18.0.9]:55982)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1ZPR44-000662-Ls
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:07:12 -0400
From: Andreas Schwab <schwab@linux-m68k.org>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-16-git-send-email-laurent@vivier.eu>
	<55CAFB98.4030308@twiddle.net>
Date: Wed, 12 Aug 2015 10:07:04 +0200
In-Reply-To: <55CAFB98.4030308@twiddle.net> (Richard Henderson's message of
	"Wed, 12 Aug 2015 00:54:00 -0700")
Message-ID: <mvma8txj5g7.fsf@hawking.suse.de>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, gerg@uclinux.org, Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org

Richard Henderson <rth@twiddle.net> writes:

> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>> +    opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD;
>> +    incr = opsize_bytes(opsize);
>> +    if (!is_load && (insn & 070) == 040) {
>> +        for (i = 15; i >= 0; i--, mask >>= 1) {
>
> This has got to be wrong.  Just because it's pre-decrement doesn't mean
> you should skip all of the loads.

Pre-dec only supports reg-to-mem, and is special because mask is bit
reversed.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."