From: Andreas Schwab <schwab@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] m68k: Pass a pointer to virt_to_pfn() virt_to_page()
Date: Thu, 23 Mar 2023 14:42:37 +0100 [thread overview]
Message-ID: <mvmfs9vwpma.fsf@linux-m68k.org> (raw)
In-Reply-To: <20230323133656.679478-1-linus.walleij@linaro.org> (Linus Walleij's message of "Thu, 23 Mar 2023 14:36:56 +0100")
On Mär 23 2023, Linus Walleij wrote:
> diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c
> index 911301224078..0a9bc8292f78 100644
> --- a/arch/m68k/mm/motorola.c
> +++ b/arch/m68k/mm/motorola.c
> @@ -102,7 +102,7 @@ static struct list_head ptable_list[2] = {
> LIST_HEAD_INIT(ptable_list[1]),
> };
>
> -#define PD_PTABLE(page) ((ptable_desc *)&(virt_to_page(page)->lru))
> +#define PD_PTABLE(page) ((ptable_desc *)&(virt_to_page((void *)page)->lru))
That should probably get a pair of parens around the macro argument.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-03-23 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 13:36 [PATCH] m68k: Pass a pointer to virt_to_pfn() virt_to_page() Linus Walleij
2023-03-23 13:42 ` Andreas Schwab [this message]
2023-03-23 15:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmfs9vwpma.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.