From: Andreas Schwab <schwab@suse.de>
To: Laurent Vivier <laurent@vivier.eu> (odd fixer:Linux user)
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Subject: [PATCH] linux-user: properly check flags in openat2
Date: Tue, 10 Feb 2026 10:26:02 +0100 [thread overview]
Message-ID: <mvmpl6d9cgl.fsf@suse.de> (raw)
target_to_host_bitmask truncates the bitmask to int. Check that the upper
half of the flags do not have any bits set.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
linux-user/syscall.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8469b81878..667aea6a03 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8822,6 +8822,10 @@ static int do_openat2(CPUArchState *cpu_env, abi_long dirfd,
}
return ret;
}
+ if (tswap64(how.flags) >> 32) {
+ return -TARGET_EINVAL;
+ }
+
pathname = lock_user_string(guest_pathname);
if (!pathname) {
return -TARGET_EFAULT;
--
2.53.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next reply other threads:[~2026-02-10 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 9:26 Andreas Schwab [this message]
2026-02-10 15:41 ` [PATCH] linux-user: properly check flags in openat2 Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmpl6d9cgl.fsf@suse.de \
--to=schwab@suse.de \
--cc=laurent@vivier.eu \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.