From: Andreas Schwab <schwab@suse.de>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Marc Stevens" <marc@marc-stevens.nl>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: Unaligned accesses in sha1dc
Date: Thu, 01 Jun 2017 11:32:07 +0200 [thread overview]
Message-ID: <mvmr2z4t5ns.fsf@suse.de> (raw)
In-Reply-To: <20170601091856.r3oaddwzsndniyfa@genre.crustytoothpaste.net> (brian m. carlson's message of "Thu, 1 Jun 2017 09:18:57 +0000")
On Jun 01 2017, "brian m. carlson" <sandals@crustytoothpaste.net> wrote:
> On Thu, Jun 01, 2017 at 10:28:52AM +0200, Andreas Schwab wrote:
>> The sh1dc implementation is making unaligned accesses, which will crash
>> on some architectures, others have to emulate them in software.
>>
>> Breakpoint 4, sha1_compression_states (ihv=0x600ffffffffe7010,
>> m=<optimized out>, W=0x600ffffffffe70a8, states=0x600ffffffffe7328)
>> at sha1dc/sha1.c:398
>> 398 SHA1COMPRESS_FULL_ROUND2_STEP(e, a, b, c, d, W, 21, temp);
>> (gdb) n
>> 403 SHA1COMPRESS_FULL_ROUND2_STEP(d, e, a, b, c, W, 22, temp);
>> (gdb)
>> 408 SHA1COMPRESS_FULL_ROUND2_STEP(c, d, e, a, b, W, 23, temp);
>> (gdb)
>> 413 SHA1COMPRESS_FULL_ROUND2_STEP(b, c, d, e, a, W, 24, temp);
>> (gdb)
>> 418 SHA1COMPRESS_FULL_ROUND2_STEP(a, b, c, d, e, W, 25, temp);
>> (gdb)
>> 291 SHA1COMPRESS_FULL_ROUND1_STEP_LOAD(a, b, c, d, e, m, W, 0, temp);
>> (gdb)
>> git(21728): unaligned access to 0x600000000009f8d5, ip=0x40000000003336d0
>> 423 SHA1COMPRESS_FULL_ROUND2_STEP(e, a, b, c, d, W, 26, temp);
>
> What architecture are you seeing this on?
It doesn't matter.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2017-06-01 9:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 8:28 Unaligned accesses in sha1dc Andreas Schwab
[not found] ` <CDB32E2C-48AF-4636-B921-4C45B614FD35@marc-stevens.nl>
2017-06-01 9:05 ` Andreas Schwab
2017-06-01 9:15 ` Junio C Hamano
2017-06-01 9:15 ` Andreas Schwab
2017-06-01 9:34 ` Junio C Hamano
2017-06-01 9:18 ` brian m. carlson
2017-06-01 9:32 ` Andreas Schwab [this message]
2017-06-01 9:21 ` Lars Schneider
2017-06-01 9:53 ` Junio C Hamano
2017-06-01 10:08 ` Andreas Schwab
2017-06-01 10:26 ` Martin Ågren
2017-06-01 10:33 ` Ævar Arnfjörð Bjarmason
2017-06-01 11:53 ` Martin Ågren
2017-06-01 15:57 ` Martin Ågren
2017-06-02 0:15 ` Junio C Hamano
2017-06-02 8:51 ` Ævar Arnfjörð Bjarmason
2017-06-02 9:49 ` Martin Ågren
2017-06-02 19:32 ` Ævar Arnfjörð Bjarmason
2017-06-02 20:11 ` Martin Ågren
2017-06-02 20:14 ` Ævar Arnfjörð Bjarmason
2017-06-02 20:25 ` demerphq
2017-06-02 20:17 ` demerphq
2017-06-02 20:38 ` Ævar Arnfjörð Bjarmason
2017-06-02 21:53 ` Linus Torvalds
2017-06-03 0:13 ` Junio C Hamano
2017-06-02 14:46 ` Liam R. Howlett
2017-06-02 16:53 ` Ævar Arnfjörð Bjarmason
2017-06-03 0:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmr2z4t5ns.fsf@suse.de \
--to=schwab@suse.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=marc@marc-stevens.nl \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.