From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752660AbcF2G50 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jun 2016 02:57:26 -0400
Received: from mx2.suse.de ([195.135.220.15]:56028 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752634AbcF2G5Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jun 2016 02:57:24 -0400
From: Andreas Schwab <schwab@suse.de>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>,
        <arnd@arndb.de>, <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>,
        <philb@gnu.org>, <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <joseph@codesourcery.com>,
        <pinskia@gmail.com>, <bamvor.zhangjian@huawei.com>,
        <fweimer@redhat.com>, <Prasun.Kapoor@cavium.com>,
        <cmetcalf@mellanox.com>, <hjl.tools@gmail.com>,
        <adhemerval.zanella@linaro.org>, Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family
References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com>
	<1467131978-669-19-git-send-email-ynorov@caviumnetworks.com>
X-Yow: The PINK SOCKS were ORIGINALLY from 1952!!
 But they went to MARS around 1953!!
Date: Wed, 29 Jun 2016 08:57:19 +0200
In-Reply-To: <1467131978-669-19-git-send-email-ynorov@caviumnetworks.com>
	(Yury Norov's message of "Tue, 28 Jun 2016 19:39:33 +0300")
Message-ID: <mvmtwgciisw.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yury Norov <ynorov@caviumnetworks.com> writes:

> +#ifdef __ILP32__
> +#include <endian.h>
> +struct __kernel_timespec
> +  {
> +    unsigned long long tv_sec;		/* Seconds.  */
> +    long long tv_nsec;			/* Nanoseconds.  */
> +  };
> +#define conv_timespec(u, k) do {	\
> +	(u)->tv_sec = (k)->tv_sec;	\
> +	(u)->tv_nsec = (k)->tv_nsec;	\
> +} while (0)
> +#if __BYTE_ORDER == __LITTLE_ENDIAN
> +#define __type3264(type, name)	\
> +	type (name); type name##_pad
> +#else
> +#define __type3264(type, name)	\
> +	type name##_pad; type name
> +#endif
> +
> +#else
> +#define __kernel_timespec timespec
> +#define conv_timespec(u, k)
> +#define __type3264(type, name) type name
> +#endif /* __ILP32__ */

Surely conv_timespec needs to be put in an internal header.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."