From: Andreas Schwab <schwab@suse.de>
To: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtla: fix double free
Date: Mon, 25 Jul 2022 15:46:40 +0200 [thread overview]
Message-ID: <mvmv8rll2yn.fsf@suse.de> (raw)
In-Reply-To: <fd0888a4-099c-95fe-7e20-82be1489061f@kernel.org> (Daniel Bristot de Oliveira's message of "Mon, 25 Jul 2022 15:34:56 +0200")
On Jul 25 2022, Daniel Bristot de Oliveira wrote:
> Hi Andreas
>
> On 7/25/22 15:10, Andreas Schwab wrote:
>> Don't call trace_instance_destroy in trace_instance_init when it fails,
>> this is done by the caller.
>
> Regarding the Subject, are you seeing a double-free error, or it is just an
> optimization?
A double free nowadays is almost always an error, due to better malloc
checking.
> AFAICS, trace_instance_destroy() checks the pointers before calling free().
That doesn't help when the pointer is not cleared afterwards. Do you
prefer that?
> Why am I asking? because if it is a double-free bug, we need to add the "Fixes:"
> tag,
It's the first time I tried running rtla, so I don't know whether it is
a regression, but from looking at the history it appears to have been
introduced already in commit 0605bf009f18 ("rtla: Add osnoise tool")
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2022-07-25 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 13:10 [PATCH] rtla: fix double free Andreas Schwab
2022-07-25 13:34 ` Daniel Bristot de Oliveira
2022-07-25 13:46 ` Andreas Schwab [this message]
2022-07-25 14:56 ` Steven Rostedt
2022-07-25 15:12 ` [PATCH v2] rtla: Fix " Andreas Schwab
2022-07-25 15:18 ` Andreas Schwab
2022-07-25 15:23 ` Daniel Bristot de Oliveira
2022-07-25 15:22 ` [PATCH] rtla: fix " Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmv8rll2yn.fsf@suse.de \
--to=schwab@suse.de \
--cc=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.