From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ken Goldman Subject: Re: Question on Linux TSS architecture design (kernel vs. user space access) Date: Wed, 23 Dec 2015 10:02:05 -0500 Message-ID: References: <9F48E1A823B03B4790B7E6E69430724DA58648F1@EXCH2010A.sit.fraunhofer.de> <201512171620.tBHGK3GE030569@d03av04.boulder.ibm.com> <9F48E1A823B03B4790B7E6E69430724DA586493C@EXCH2010A.sit.fraunhofer.de> <20151218105148.GA12882@intel.com> <20151218105323.GB12882@intel.com> <20151218114131.GA3287@intel.com> <9F48E1A823B03B4790B7E6E69430724DA586A57C@EXCH2010B.sit.fraunhofer.de> <20151222212348.GB9461@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151222212348.GB9461-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On 12/22/2015 4:23 PM, Jason Gunthorpe wrote: > > I'd be alarmed if it is that much. The TPM format is very amenable to > doing this, a well designed table driven approach should be quite > small on the rpc handling side. The key is to not overthink/overdesign > it too much. Let's expand on "alarmed". If that just means you're surprised, OK. If it means the code will be rejected based solely on the size, please tell us now. > I have an entire tpm1.2 userpace in less than 2kloc, so I struggle to > see why a simple resource manager would be so big. > > 1-2kloc is not a big deal kernel wise if it is well written and in the > kernel style. Similar question. Let's assume it's 5 kloc, or even more. Can it be accepted or not? I don't want to go down the TPM 1.2 path, where IBM funded several projects and they were all rejected, not after any technical evaluation, but simply based on LOC. ------------------------------------------------------------------------------