From: Matthias Koenig <mkoenig@suse.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH] e2fsprogs: avoid double free of ctx->filesystem_name in e2fsck
Date: Mon, 07 Apr 2008 12:33:25 +0200 [thread overview]
Message-ID: <n7x4paegdje.fsf@sor.suse.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
Hi,
in current git there is a double free on ctx->filesystem_name in the end of
main() and in e2fsck_free_context, causing e2fsck to abort at the end of
pass5.
Matthias
Signed-off-by: Matthias Koenig <mkoenig@suse.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: e2fsprogs-fsck_avoid_double_free.patch --]
[-- Type: text/x-patch, Size: 399 bytes --]
Index: e2fsprogs-1.40.8+NEXT+git20080401/e2fsck/unix.c
===================================================================
--- e2fsprogs-1.40.8+NEXT+git20080401.orig/e2fsck/unix.c
+++ e2fsprogs-1.40.8+NEXT+git20080401/e2fsck/unix.c
@@ -1366,7 +1366,6 @@ no_journal:
#endif
ext2fs_close(fs);
ctx->fs = NULL;
- free(ctx->filesystem_name);
free(ctx->journal_name);
e2fsck_free_context(ctx);
next reply other threads:[~2008-04-07 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 10:33 Matthias Koenig [this message]
2008-04-07 15:51 ` [PATCH] e2fsprogs: avoid double free of ctx->filesystem_name in e2fsck Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n7x4paegdje.fsf@sor.suse.de \
--to=mkoenig@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.