All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] hwmon: Cleanup w83627hf initialization
Date: Wed, 05 Oct 2005 10:42:57 +0000	[thread overview]
Message-ID: <nLu76Kd1.1128501171.2234810.khali@localhost> (raw)
In-Reply-To: <20051004200848.5f4f0182.khali@linux-fr.org>


Hi Salah,

On 2005-10-05, Salah Coronya wrote:
> It works for me just fine, actually it works BETTER. before pwm1 and
> pwm2 were reversed (pwm1 controlled fan2; and pwm2 controller fan1), and
> the fan2 would always report 0 no matter what the fan speed was. Now the
> reading and controls are correct, or at least more plausible. (Unless it
> was another patch between 2.6.13 and 2.6.13-r3).

I assume you mean 2.6.14-rc3? Yes there was a patch which made the chip
reset on driver load optional (and off by default). This is much more
likely to cause the improvements you observe than my new patch. You
could try loading the w83627hf driver with reset=1 and see if everything
reverts to the old behavior. I admit I'm a bit surprised that PWM
outputs were swapped, as I don't think the W83627HF hardware monitoring
logical device can actually do that.

Also note that the second patch really only affects the W83627HF chip,
not W83637HF, W83627THF nor W83697HF. Not sure which one you have.

Anyway, if everything works OK for you with these two patches applied,
that's great :) Thanks for testing.

--
Jean Delvare

      parent reply	other threads:[~2005-10-05 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-04 20:09 [lm-sensors] [PATCH] hwmon: Cleanup w83627hf initialization Jean Delvare
2005-10-05  6:14 ` Salah Coronya
2005-10-05 10:42 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nLu76Kd1.1128501171.2234810.khali@localhost \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.