From: Theodore Ts'o <tytso@mit.edu>
To: linux-ext4@vger.kernel.org
Cc: Tao Ma <tm@tao.ma>
Subject: RFC: remove CONFIG_EXT4_FS_XATTR
Date: Wed, 05 Dec 2012 17:35:05 -0500 [thread overview]
Message-ID: <nsxsj7kw2jq.fsf@closure.thunk.org> (raw)
The number of build warnings that were generated with the inline data
patch makes me think that perhaps we should just remove
CONFIG_EXT4_FS_XATTR. Turning off CONFIG_EXT4_FS_XATTR causes a net
decrease in the ext4 file system by 27k (about 7.3% if ext4 is built as
a module; the entire compiled kernel's text+data size for my
all-in-one-no-modules-for-kvm-testing is 19 megabytes).
Another advantage of making this change is with the inline data option,
if you turn off CONFIG_EXT4_FS_XATTR, it will still allow a file system
with inline_data to be mounted, but then attempts to read small files or
small directories will end up returning EOPNOTSUPP, which will be
surprising to end users in a very serious way. (Assuming it works at
all; I haven't tested to make sure it fails cleanly, and I'm not sure
Tao has tested that case either; so easing our test matrix is another
reason why removing this config option would be helpful.)
Does anyone have any objections or other reasons why this would be a bad
idea?
- Ted
next reply other threads:[~2012-12-05 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 22:35 Theodore Ts'o [this message]
2012-12-05 23:04 ` RFC: remove CONFIG_EXT4_FS_XATTR Eric Sandeen
2012-12-06 1:33 ` Tao Ma
2012-12-06 3:48 ` Theodore Ts'o
2012-12-06 19:28 ` David Brown
2012-12-06 10:26 ` Jan Kara
2012-12-10 6:19 ` [PATCH] ext4: Remove CONFIG_EXT4_FS_XATTR Tao Ma
2012-12-10 10:08 ` Jan Kara
2012-12-10 15:11 ` [PATCH V2] " Tao Ma
2012-12-10 19:21 ` [PATCH] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nsxsj7kw2jq.fsf@closure.thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.