All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH v2] autoconf-archive: 2012.04.07 -> 2016.09.16
Date: Sat, 8 Oct 2016 14:09:36 +0200	[thread overview]
Message-ID: <ntanlu$nkt$1@blaine.gmane.org> (raw)
In-Reply-To: <1475854216-6859-1-git-send-email-msbarth@linux.vnet.ibm.com>

Op 07-10-16 om 17:30 schreef Matthew Barth:
> Signed-off-by: Matthew Barth <msbarth@linux.vnet.ibm.com>
> ---
>  meta-oe/recipes-devtools/autoconf-archive/autoconf-archive.inc    | 7 ++++---
>  ...oconf-archive_2012.04.07.bb => autoconf-archive_2016.09.16.bb} | 8 +++-----
>  2 files changed, 7 insertions(+), 8 deletions(-)
>  rename meta-oe/recipes-devtools/autoconf-archive/{autoconf-archive_2012.04.07.bb => autoconf-archive_2016.09.16.bb} (55%)
> 
> diff --git a/meta-oe/recipes-devtools/autoconf-archive/autoconf-archive.inc b/meta-oe/recipes-devtools/autoconf-archive/autoconf-archive.inc
> index 9399363..2b5df70 100644
> --- a/meta-oe/recipes-devtools/autoconf-archive/autoconf-archive.inc
> +++ b/meta-oe/recipes-devtools/autoconf-archive/autoconf-archive.inc
> @@ -1,15 +1,16 @@
> +SUMMARY = "A collection of macros for GNU Autoconf"
> +DESCRIPTION = "The autoconf-archive set of macros extend the pre-defined \
> +capabilities within the complete autoconf tool set."
>  LICENSE = "GPLv3"
>  HOMEPAGE = "http://www.gnu.org/software/autoconf-archive/"
>  SECTION = "devel"
> -
>  DEPENDS += "m4-native"
>  DEPENDS_class-native = "m4-native gnu-config-native"
>  DEPENDS_class-nativesdk = "m4-nativesdk gnu-config-nativesdk"
> -
>  RDEPENDS_${PN} = "m4 gnu-config"
>  RDEPENDS_${PN}_class-native = "m4-native gnu-config-native"
>  RDEPENDS_${PN}_class-nativesdk = "m4-nativesdk gnu-config-nativesdk"

Removing that whitespace makes the recipe less readable. And like I said
before, if you're going to touch style issues, move R* below do_install





  reply	other threads:[~2016-10-08 12:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 15:30 [meta-oe][PATCH v2] autoconf-archive: 2012.04.07 -> 2016.09.16 Matthew Barth
2016-10-08 12:09 ` Koen Kooi [this message]
2016-10-12 20:26 ` Martin Jansa
2016-10-24 16:55   ` msbarth
2016-10-24 17:17     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ntanlu$nkt$1@blaine.gmane.org' \
    --to=koen@dominion.thruhere.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.