All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Pilcher <arequipeno@gmail.com>
To: dm-devel@redhat.com
Subject: Re: dm-cache: please check/repair metadata
Date: Sat, 17 Dec 2016 18:34:34 -0600	[thread overview]
Message-ID: <o34lim$19u$1@blaine.gmane.org> (raw)
In-Reply-To: <efe12356-a132-c517-914d-4a4cf3a902fc@gmail.com>

On 12/08/2016 08:53 AM, Ian Pilcher wrote:
> Running cache_repair against the metadata device gives me this error:
>
>   transaction_manager::new_block() couldn't allocate new block
>
> I strongly suspect that my metadata device is too small.  It was sized
> with the algorithm that I posted to this list about a year ago:
>
>   https://www.redhat.com/archives/dm-devel/2015-November/msg00221.html
>
> Looking at the source code for cache_metadata_size, I see that it adds
> additional space for "hints", which the old algorithm didn't account
> for.

I finally got around to testing my hypothesis, and I can confirm that
the size of the metadata device is indeed the problem.  With a larger
metadata device, cache_repair succeeds, and I am able to assemble the
cache device.

So I obviously need to change the formula that I'm using to calculate
the size of the metadata device, which begs the question ... what is the
CANONICAL formula for doing this?

lvmcache(7) says, "The size of this LV should be 1000 times smaller
than the cache data LV, with a minimum size of 8MiB."  But this is
definitely *not* the formula used by cache_metadata_size, and
cache_metadata_size seems to assume that hints will never be larger
than 4 bytes.

-- 
========================================================================
Ian Pilcher                                         arequipeno@gmail.com
-------- "I grew up before Mark Zuckerberg invented friendship" --------
========================================================================

  reply	other threads:[~2016-12-18  0:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08  1:36 dm-cache: please check/repair metadata Ian Pilcher
2016-12-08 10:23 ` Zdenek Kabelac
2016-12-08 14:53   ` Ian Pilcher
2016-12-18  0:34     ` Ian Pilcher [this message]
2016-12-18 12:44       ` Zdenek Kabelac
2016-12-18 15:51         ` Ian Pilcher
2016-12-18 19:37           ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='o34lim$19u$1@blaine.gmane.org' \
    --to=arequipeno@gmail.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.