All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/5] s390/pci: Move three assignments for the variable "rc" in clp_normal_command()
Date: Sun, 22 Jan 2017 08:58:07 +0100	[thread overview]
Message-ID: <o61omd$vb4$1@blaine.gmane.org> (raw)
In-Reply-To: <d8178ea8-8a46-b922-c486-d741dd916565@users.sourceforge.net>

Le 21/01/2017 à 19:12, SF Markus Elfring a écrit :
> @@ -541,9 +543,8 @@ static int clp_normal_command(struct clp_req *req)
>   	if (rc)
>   		goto out_free;
>   
> -	rc = -EFAULT;
>   	if (copy_to_user(uptr, lpcb, PAGE_SIZE) != 0)
> -		goto out_free;
> +		rc = -EFAULT;
>   
>   	rc = 0;
>   

With this, we return 0 (success) on error.

CJ

  parent reply	other threads:[~2017-01-22  7:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 18:09 [PATCH 0/5] s390/pci: Fine-tuning for three function implementations SF Markus Elfring
2017-01-21 18:09 ` SF Markus Elfring
2017-01-21 18:10 ` [PATCH 1/5] s390/pci: Return directly after a failed parameter validation in clp_normal_command() SF Markus Elfring
2017-01-21 18:10   ` SF Markus Elfring
2017-01-21 18:11 ` [PATCH 2/5] s390/pci: Return directly after a failed clp_alloc_block() " SF Markus Elfring
2017-01-21 18:11   ` SF Markus Elfring
2017-01-21 18:12 ` [PATCH 3/5] s390/pci: Move three assignments for the variable "rc" " SF Markus Elfring
2017-01-21 18:12   ` SF Markus Elfring
2017-01-21 19:20   ` kbuild test robot
2017-01-21 19:20     ` kbuild test robot
2017-01-22  7:58   ` Christophe JAILLET [this message]
2017-01-21 18:13 ` [PATCH 4/5] s390/pci: Move an assignment for the variable "ret" in s390_pci_mmio_write() SF Markus Elfring
2017-01-21 18:13   ` SF Markus Elfring
2017-01-23  8:58   ` Dan Carpenter
2017-01-23  8:58     ` Dan Carpenter
2017-01-21 18:14 ` [PATCH 5/5] s390/pci: Move two assignments for the variable "ret" in get_pfn() SF Markus Elfring
2017-01-21 18:14   ` SF Markus Elfring
2017-01-23  8:55 ` [PATCH 0/5] s390/pci: Fine-tuning for three function implementations Dan Carpenter
2017-01-23  8:55   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='o61omd$vb4$1@blaine.gmane.org' \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.