From: Ken Goldman <kgoldman-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n>
Date: Fri, 27 Jan 2017 17:01:52 -0500 [thread overview]
Message-ID: <o6gg06$4j6$1@blaine.gmane.org> (raw)
In-Reply-To: <1485209797.2534.29.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
On 1/23/2017 5:16 PM, James Bottomley wrote:
>
> because the 0x9XX return codes don't have any parameter information
> that needs stripping and (rc & TPM2_RC_REFERENCE_H0) ==
> TPM2_RC_REFERENCE_H0) will match any error code that has bits 11, 8
> and 5 set.
>
> I think the handle check was wrong too, it should have been
>
> if (rc & 0xff) == TPM2_RC_HANDLE)
>
> Because all you need to do is strip off the parameter information
This is just FYI ...
The TPM feature that adds parameter or handle numbers to the return code
is optional. So, masking them out is OK, but don't do anything that
requires that 3 bit field to be accurate.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-01-27 22:01 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:12 [PATCH RFC v3 0/5] RFC: in-kernel resource manager Jarkko Sakkinen
2017-01-16 13:12 ` Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 2/5] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen
2017-01-16 13:12 ` Jarkko Sakkinen
[not found] ` <20170116131215.28930-1-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-01-16 13:12 ` [PATCH RFC v3 1/5] tpm: validate TPM 2.0 commands Jarkko Sakkinen
2017-01-16 13:12 ` Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 3/5] tpm: infrastructure for TPM spaces Jarkko Sakkinen
2017-01-16 13:12 ` Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n> Jarkko Sakkinen
2017-01-16 13:12 ` Jarkko Sakkinen
2017-01-16 16:14 ` Jason Gunthorpe
2017-01-16 17:24 ` Jarkko Sakkinen
2017-01-16 17:28 ` [tpmdd-devel] " James Bottomley
2017-01-17 7:14 ` Jarkko Sakkinen
2017-01-18 15:01 ` James Bottomley
2017-01-19 10:49 ` Jarkko Sakkinen
2017-01-19 12:19 ` James Bottomley
2017-01-20 13:39 ` Jarkko Sakkinen
[not found] ` <20170120133914.2wk43nteh2hh7n3c-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-20 21:05 ` Jarkko Sakkinen
2017-01-20 21:05 ` [tpmdd-devel] " Jarkko Sakkinen
2017-01-21 19:28 ` James Bottomley
[not found] ` <1485026935.26703.12.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-22 14:49 ` Jarkko Sakkinen
2017-01-22 14:49 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20170120210522.glx4y4oui36oimld-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-21 20:38 ` James Bottomley
2017-01-21 20:38 ` [tpmdd-devel] " James Bottomley
[not found] ` <1485031136.26703.16.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-22 14:49 ` Jarkko Sakkinen
2017-01-22 14:49 ` [tpmdd-devel] " Jarkko Sakkinen
2017-01-22 17:49 ` James Bottomley
2017-01-22 18:48 ` James Bottomley
2017-01-22 20:30 ` Jarkko Sakkinen
2017-01-22 21:01 ` Jarkko Sakkinen
2017-01-22 21:04 ` Jarkko Sakkinen
2017-01-22 21:36 ` James Bottomley
2017-01-23 14:09 ` Jarkko Sakkinen
[not found] ` <20170123140942.svnurymdxsyo6cum-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-23 16:14 ` James Bottomley
2017-01-23 16:14 ` [tpmdd-devel] " James Bottomley
[not found] ` <1485188095.2534.6.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-24 12:03 ` Jarkko Sakkinen
2017-01-24 12:03 ` [tpmdd-devel] " Jarkko Sakkinen
2017-01-23 16:58 ` Jarkko Sakkinen
[not found] ` <20170123165823.hbgwphsqqpn6jwiz-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-23 21:42 ` Jarkko Sakkinen
2017-01-23 21:42 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20170123214255.vt2dumjm6jo5oxd3-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-23 22:16 ` James Bottomley
2017-01-23 22:16 ` [tpmdd-devel] " James Bottomley
2017-01-25 13:40 ` Jarkko Sakkinen
2017-01-25 13:42 ` Jarkko Sakkinen
[not found] ` <20170125134004.g77ezmfkkhya643y-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-27 0:29 ` James Bottomley
2017-01-27 0:29 ` [tpmdd-devel] " James Bottomley
[not found] ` <1485476942.2457.45.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-27 6:45 ` Jarkko Sakkinen
2017-01-27 6:45 ` [tpmdd-devel] " Jarkko Sakkinen
2017-01-25 20:23 ` Jarkko Sakkinen
[not found] ` <1485209797.2534.29.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-27 22:01 ` Ken Goldman [this message]
[not found] ` <1485107342.2504.7.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-22 20:24 ` Jarkko Sakkinen
2017-01-22 20:24 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20170116131215.28930-6-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-01-19 10:42 ` Jarkko Sakkinen
2017-01-19 10:42 ` Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen
2017-01-16 13:12 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='o6gg06$4j6$1@blaine.gmane.org' \
--to=kgoldman-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.