From mboxrd@z Thu Jan 1 00:00:00 1970 From: ramsdell@mitre.org (John D. Ramsdell) Subject: Mini-os buglet (integer in xenbus/xenbus_xs.c should be unsigned) Date: 05 Apr 2006 11:34:47 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org I'm running on a 32-bit x86 machine with Fedora Core 5. There is a problem that causes a compilation failure when building mini-os from its sources. An integer in xenbus/xenbus_xs.c should be unsigned. Furthermore, a use of "xm top" asks me to report a bug to this list. John $ diff -ur oxen-3.0.1 xen-3.0.1 Only in xen-3.0.1/extras/mini-os: events.o Only in xen-3.0.1/extras/mini-os: hypervisor.o Only in xen-3.0.1/extras/mini-os/include: xen Only in xen-3.0.1/extras/mini-os: kernel.o Only in xen-3.0.1/extras/mini-os/lib: math.o Only in xen-3.0.1/extras/mini-os/lib: printf.o Only in xen-3.0.1/extras/mini-os/lib: string.o Only in xen-3.0.1/extras/mini-os/lib: xmalloc.o Only in xen-3.0.1/extras/mini-os: mini-os.elf Only in xen-3.0.1/extras/mini-os: mini-os.gz Only in xen-3.0.1/extras/mini-os: mm.o Only in xen-3.0.1/extras/mini-os: sched.o Only in xen-3.0.1/extras/mini-os: time.o Only in xen-3.0.1/extras/mini-os: traps.o Only in xen-3.0.1/extras/mini-os: x86_32.o Only in xen-3.0.1/extras/mini-os/xenbus: xenbus_comms.o diff -ur oxen-3.0.1/extras/mini-os/xenbus/xenbus_xs.c xen-3.0.1/extras/mini-os/xenbus/xenbus_xs.c --- oxen-3.0.1/extras/mini-os/xenbus/xenbus_xs.c 2006-03-01 17:38:57.000000000 -0500 +++ xen-3.0.1/extras/mini-os/xenbus/xenbus_xs.c 2006-04-05 10:56:21.000000000 -0400 @@ -335,7 +335,7 @@ const char *dir, const char *node) { char **d; - int dir_n; + unsigned int dir_n; d = xenbus_directory(t, dir, node, &dir_n); if (IS_ERR(d)) Only in xen-3.0.1/extras/mini-os/xenbus: xenbus_xs.c~ Only in xen-3.0.1/extras/mini-os/xenbus: xenbus_xs.o Only in xen-3.0.1/extras/mini-os/xenbus: xenstored.h [ramsdell@goo mini-os]$ su Password: [root@goo mini-os]# pwd /home/ramsdell/src/xen-3.0.1/extras/mini-os [root@goo mini-os]# /usr/sbin/xm create domain_config Using config file "domain_config". Started domain Mini-OS [root@goo mini-os]# /usr/sbin/xm top Unexpected error: exceptions.OSError Please report to xen-devel@lists.xensource.com Traceback (most recent call last): File "/usr/sbin/xm", line 10, in ? main.main(sys.argv) File "/usr/lib/python2.4/site-packages/xen/xm/main.py", line 1021, in main rc = cmd(args) File "/usr/lib/python2.4/site-packages/xen/xm/main.py", line 654, in xm_top os.execvp('xentop', ['xentop']) File "/usr/lib/python2.4/os.py", line 341, in execvp _execvpe(file, args) File "/usr/lib/python2.4/os.py", line 379, in _execvpe func(fullname, *argrest) OSError: [Errno 2] No such file or directory [root@goo mini-os]# /usr/sbin/xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 1416 1 r----- 41.9 Mini-OS 1 32 1 ------ 8.6 [root@goo mini-os]# /usr/sbin/xm destroy Mini-OS [root@goo mini-os]# /usr/sbin/xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 1416 1 r----- 46.2 [root@goo mini-os]#