From mboxrd@z Thu Jan 1 00:00:00 1970 From: "johann deneux" Subject: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 19:56:18 +0100 Message-ID: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_93149_17867281.1171565778708" Return-path: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: linux-input , dmitry Cc: Valentin Zagura List-Id: linux-input@vger.kernel.org ------=_Part_93149_17867281.1171565778708 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline This patch (initially submitted by Valentin Zagura) adds the Logitech Formula Force EX to the list of devices handled by hid-lgff. Also updated the text of the Kconfig entry. Signed-off-by: Johann Deneux --- linux-2.6.20.orig/drivers/usb/input/Kconfig 2007-02-04 19:44: 54.000000000 +0100 +++ linux-2.6.20/drivers/usb/input/Kconfig 2007-02-15 12:27:42.000000000+0100 @@ -56,17 +56,21 @@ config HID_PID Say Y here if you have a PID-compliant device and wish to enable force feedback for it. Microsoft Sidewinder Force Feedback 2 is one of such devices. config LOGITECH_FF - bool "Logitech WingMan *3D support" + bool "Logitech devices support" depends on HID_FF select INPUT_FF_MEMLESS if USB_HID help Say Y here if you have one of these devices: - Logitech WingMan Cordless RumblePad + - Logitech WingMan Cordless RumblePad 2 - Logitech WingMan Force 3D + - Logitech Formula Force EX + - Logitech MOMO Force wheel + and if you want to enable force feedback for them. Note: if you say N here, this device will still be supported, but without force feedback. config THRUSTMASTER_FF --- linux-2.6.20.orig/drivers/usb/input/hid-ff.c 2007-02-04 19:44: 54.000000000 +0100 +++ linux-2.6.20/drivers/usb/input/hid-ff.c 2007-02-15 12:16:53.000000000+0100 @@ -53,10 +53,11 @@ struct hid_ff_initializer { */ static struct hid_ff_initializer inits[] = { #ifdef CONFIG_LOGITECH_FF { 0x46d, 0xc211, hid_lgff_init }, /* Logitech Cordless rumble pad */ { 0x46d, 0xc283, hid_lgff_init }, /* Logitech Wingman Force 3d */ + { 0x46d, 0xc294, hid_lgff_init }, /* Logitech Formula Force EX */ { 0x46d, 0xc295, hid_lgff_init }, /* Logitech MOMO force wheel */ { 0x46d, 0xc219, hid_lgff_init }, /* Logitech Cordless rumble pad 2 */ #endif #ifdef CONFIG_THRUSTMASTER_FF { 0x44f, 0xb304, hid_tmff_init }, ------=_Part_93149_17867281.1171565778708 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline This patch (initially submitted by Valentin Zagura) adds the Logitech Formula Force EX to the list of devices handled by hid-lgff.
Also updated the text of the Kconfig entry.

Signed-off-by: Johann Deneux < johann.deneux@gmail.com>

--- linux-2.6.20.orig/drivers/usb/input/Kconfig    2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6.20/drivers/usb/input/Kconfig    2007-02-15 12:27:42.000000000 +0100
@@ -56,17 +56,21 @@ config HID_PID
       Say Y here if you have a PID-compliant device and wish to enable force
       feedback for it. Microsoft Sidewinder Force Feedback 2 is one of such
       devices.
 
 config LOGITECH_FF
-    bool "Logitech WingMan *3D support"
+    bool "Logitech devices support"
     depends on HID_FF
     select INPUT_FF_MEMLESS if USB_HID
     help
       Say Y here if you have one of these devices:
       - Logitech WingMan Cordless RumblePad
+      - Logitech WingMan Cordless RumblePad 2
       - Logitech WingMan Force 3D
+      - Logitech Formula Force EX
+      - Logitech MOMO Force wheel
+
       and if you want to enable force feedback for them.
       Note: if you say N here, this device will still be supported, but without
       force feedback.
 
 config THRUSTMASTER_FF
--- linux-2.6.20.orig/drivers/usb/input/hid-ff.c    2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6.20/drivers/usb/input/hid-ff.c    2007-02-15 12:16:53.000000000 +0100
@@ -53,10 +53,11 @@ struct hid_ff_initializer {
  */
 static struct hid_ff_initializer inits[] = {
 #ifdef CONFIG_LOGITECH_FF
     { 0x46d, 0xc211, hid_lgff_init }, /* Logitech Cordless rumble pad */
     { 0x46d, 0xc283, hid_lgff_init }, /* Logitech Wingman Force 3d */
+    { 0x46d, 0xc294, hid_lgff_init }, /* Logitech Formula Force EX */
     { 0x46d, 0xc295, hid_lgff_init }, /* Logitech MOMO force wheel */
     { 0x46d, 0xc219, hid_lgff_init }, /* Logitech Cordless rumble pad 2 */
 #endif
 #ifdef CONFIG_THRUSTMASTER_FF
     { 0x44f, 0xb304, hid_tmff_init },

------=_Part_93149_17867281.1171565778708-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 14:17:13 -0500 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: johann deneux Cc: linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org On 2/15/07, johann deneux wrote: > > config LOGITECH_FF > - bool "Logitech WingMan *3D support" > + bool "Logitech devices support" I think I'll change this to "Logitech devices support (WingMan, etc)" and apply. Thanks! -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: "STenyaK (Bruno Gonzalez)" Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 20:40:59 +0100 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; delsp=yes; charset=iso-8859-15 Content-Transfer-Encoding: Quoted-Printable Return-path: In-Reply-To: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: johann deneux , linux-input , dmitry Cc: Valentin Zagura List-Id: linux-input@vger.kernel.org Sorry for not providing a proper patch, could you please also add {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel to the list? I tested it here and that wheel is also working. On Thu, 15 Feb 2007 19:56:18 +0100, johann deneux = wrote: > This patch (initially submitted by Valentin Zagura) adds the Logitech > Formula Force EX to the list of devices handled by hid-lgff. > Also updated the text of the Kconfig entry. > > Signed-off-by: Johann Deneux > > --- linux-2.6.20.orig/drivers/usb/input/Kconfig 2007-02-04 19:44: > 54.000000000 +0100 > +++ linux-2.6.20/drivers/usb/input/Kconfig 2007-02-15 = > 12:27:42.000000000+0100 > @@ -56,17 +56,21 @@ config HID_PID > Say Y here if you have a PID-compliant device and wish to enabl= e > force > feedback for it. Microsoft Sidewinder Force Feedback 2 is one o= f = > such > devices. > > config LOGITECH_FF > - bool "Logitech WingMan *3D support" > + bool "Logitech devices support" > depends on HID_FF > select INPUT_FF_MEMLESS if USB_HID > help > Say Y here if you have one of these devices: > - Logitech WingMan Cordless RumblePad > + - Logitech WingMan Cordless RumblePad 2 > - Logitech WingMan Force 3D > + - Logitech Formula Force EX > + - Logitech MOMO Force wheel > + > and if you want to enable force feedback for them. > Note: if you say N here, this device will still be supported, b= ut > without > force feedback. > > config THRUSTMASTER_FF > --- linux-2.6.20.orig/drivers/usb/input/hid-ff.c 2007-02-04 19:44: > 54.000000000 +0100 > +++ linux-2.6.20/drivers/usb/input/hid-ff.c 2007-02-15 > 12:16:53.000000000+0100 > @@ -53,10 +53,11 @@ struct hid_ff_initializer { > */ > static struct hid_ff_initializer inits[] =3D { > #ifdef CONFIG_LOGITECH_FF > { 0x46d, 0xc211, hid_lgff_init }, /* Logitech Cordless rumble pad= */ > { 0x46d, 0xc283, hid_lgff_init }, /* Logitech Wingman Force 3d */= > + { 0x46d, 0xc294, hid_lgff_init }, /* Logitech Formula Force EX */= > { 0x46d, 0xc295, hid_lgff_init }, /* Logitech MOMO force wheel */= > { 0x46d, 0xc219, hid_lgff_init }, /* Logitech Cordless rumble pad= 2 = > */ > #endif > #ifdef CONFIG_THRUSTMASTER_FF > { 0x44f, 0xb304, hid_tmff_init }, -- = Saludos, STenyaK _______________________________________________ Site: http://1ksurvivor.homeip.net <1kSurvivor> http://motorsport-sim.org http://kwh.iespana.es http://emuletutorial.info ICQ: 153709484 Mail: stenyak AT gmail DOT net From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 14:42:16 -0500 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: "STenyaK (Bruno Gonzalez)" Cc: johann deneux , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > Sorry for not providing a proper patch, could you please also add > {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > to the list? I tested it here and that wheel is also working. > OK. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 14:46:38 -0500 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: "STenyaK (Bruno Gonzalez)" Cc: johann deneux , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org On 2/15/07, Dmitry Torokhov wrote: > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > > Sorry for not providing a proper patch, could you please also add > > {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > > to the list? I tested it here and that wheel is also working. > > > > OK. Wait, 0x46d:0xc294 is device being added by the original patch as Formula Force EX... Confused. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anssi Hannula Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 21:51:07 +0200 Message-ID: <45D4B9AB.70509@gmail.com> References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: "STenyaK (Bruno Gonzalez)" , johann deneux , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org Dmitry Torokhov wrote: > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: >> Sorry for not providing a proper patch, could you please also add >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel >> to the list? I tested it here and that wheel is also working. >> > > OK. > Hmm.. Shouldn't an entry also be added to the devices[] list in hid-lgff.c for these devices? (and it seems one device is already missing from there in the current kernel). I'm not able to check right now, but I think some earlier kernels may have defaulted to ff_joystick if no entry is present in devices[], hence these devices working for some without the entry. (so the alternative is to restore that behaviour) BTW, shouldn't the PID/VID check in hid_lgff_init() do endian conversion? -- Anssi Hannula From mboxrd@z Thu Jan 1 00:00:00 1970 From: "STenyaK (Bruno Gonzalez)" Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 20:53:43 +0100 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; delsp=yes; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: johann deneux , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org I guess both steering wheels share the same model ID? I don't know, but I can tell the FFB didn't work until i added that line and recompiled my kernel. I got the ID using the "usbview" tool. On Thu, 15 Feb 2007 20:46:38 +0100, Dmitry Torokhov wrote: > On 2/15/07, Dmitry Torokhov wrote: >> On 2/15/07, STenyaK (Bruno Gonzalez) wrote: >> > Sorry for not providing a proper patch, could you please also add >> > {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel >> > to the list? I tested it here and that wheel is also working. >> > >> >> OK. > > Wait, 0x46d:0xc294 is device being added by the original patch as > Formula Force EX... Confused. > -- Saludos, STenyaK _______________________________________________ Site: http://1ksurvivor.homeip.net <1kSurvivor> http://motorsport-sim.org http://kwh.iespana.es http://emuletutorial.info ICQ: 153709484 Mail: stenyak AT gmail DOT net From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 15:09:50 -0500 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> <45D4B9AB.70509@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45D4B9AB.70509@gmail.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Anssi Hannula Cc: "STenyaK (Bruno Gonzalez)" , johann deneux , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org On 2/15/07, Anssi Hannula wrote: > Dmitry Torokhov wrote: > > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > >> Sorry for not providing a proper patch, could you please also add > >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > >> to the list? I tested it here and that wheel is also working. > >> > > > > OK. > > > > Hmm.. Shouldn't an entry also be added to the devices[] list in > hid-lgff.c for these devices? (and it seems one device is already > missing from there in the current kernel). > Yep. It looks like they should be mapped to ff_joystick, right? > I'm not able to check right now, but I think some earlier kernels may > have defaulted to ff_joystick if no entry is present in devices[], hence > these devices working for some without the entry. > (so the alternative is to restore that behaviour) > > BTW, shouldn't the PID/VID check in hid_lgff_init() do endian conversion? > No, because input_id keeps this data in host format. See usb_to_input_id(). -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Valentin Zagura" Subject: Re: [PATCH] Added device to hid-ff Date: Fri, 16 Feb 2007 10:05:41 +0000 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_2402_3298952.1171620341336" Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: "STenyaK (Bruno Gonzalez)" , johann deneux , linux-input List-Id: linux-input@vger.kernel.org ------=_Part_2402_3298952.1171620341336 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline > > > > Wait, 0x46d:0xc294 is device being added by the original patch as > Formula Force EX... Confused. > Here is what I found on the net, maybe it will clear things out: http://siv.mysite.wanadoo-members.co.uk/downloads/usbdevs.txt 046D:C294=Logitech Driving Force USB (HID) 046D:C294:2000=Logitech Driving Force EX USB (HID) 046D:C294:2100=Logitech Formula Force RX USB (HID) 046D:C294:2200=Logitech Driving Force RX USB (HID) I have the EX model. Valentin Zagura ------=_Part_2402_3298952.1171620341336 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline


Wait, 0x46d:0xc294 is device being added by the original patch as
Formula Force EX... Confused.

Here is what I found on the net, maybe it will clear things out:
http://siv.mysite.wanadoo-members.co.uk/downloads/usbdevs.txt 
046D:C294=Logitech Driving Force USB (HID)
046D:C294:2000=Logitech Driving Force EX USB (HID)
046D:C294:2100=Logitech Formula Force RX USB (HID)
046D:C294:2200=Logitech Driving Force RX USB (HID)

I have the EX model.

Valentin Zagura
------=_Part_2402_3298952.1171620341336-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: "STenyaK (Bruno Gonzalez)" Subject: Re: [PATCH] Added device to hid-ff Date: Fri, 16 Feb 2007 16:20:38 +0100 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; delsp=yes; charset=iso-8859-15 Content-Transfer-Encoding: Quoted-Printable Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Valentin Zagura , Dmitry Torokhov Cc: johann deneux , linux-input List-Id: linux-input@vger.kernel.org On Fri, 16 Feb 2007 11:05:41 +0100, Valentin Zagura = wrote: > Here is what I found on the net, maybe it will clear things out: > http://siv.mysite.wanadoo-members.co.uk/downloads/usbdevs.txt > > 046D:C294=3DLogitech Driving Force USB (HID) > 046D:C294:2000=3DLogitech Driving Force EX USB (HID) > 046D:C294:2100=3DLogitech Formula Force RX USB (HID) > 046D:C294:2200=3DLogitech Driving Force RX USB (HID) My wheel doesn't appear there. It's a new model (just a few months old).= This is the whole usbview output: --------------------------------------------------------------------- G25 Racing Wheel Speed: 12Mb/s (full) USB Version: 2.00 Device Class: 00(>ifc ) Device Subclass: 00 Device Protocol: 00 Maximum Default Endpoint Size: 16 Number of Configurations: 1 Vendor Id: 046d Product Id: c294 Revision Number: 12.22 Config Number: 1 Number of Interfaces: 1 Attributes: 80 MaxPower Needed: 80mA Interface Number: 0 Name: usbhid Alternate Number: 0 Class: 03(HID ) Sub Class: 0 Protocol: 0 Number of Endpoints: 2 Endpoint Address: 81 Direction: in Attribute: 3 Type: Int. Max Packet Size: 8 Interval: 10ms Endpoint Address: 01 Direction: out Attribute: 3 Type: Int. Max Packet Size: 8 Interval: 10ms --------------------------------------------------------------------- -- = Saludos, STenyaK _______________________________________________ Site: http://1ksurvivor.homeip.net <1kSurvivor> http://motorsport-sim.org http://kwh.iespana.es http://emuletutorial.info ICQ: 153709484 Mail: stenyak AT gmail DOT net From mboxrd@z Thu Jan 1 00:00:00 1970 From: "johann deneux" Subject: Re: [PATCH] Added device to hid-ff Date: Fri, 16 Feb 2007 16:43:54 +0100 Message-ID: <38b3b7c0702160743g67ae3e55pbccad84eefc2368b@mail.gmail.com> References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> <45D4B9AB.70509@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_6263_4452801.1171640634515" Return-path: In-Reply-To: <45D4B9AB.70509@gmail.com> Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Anssi Hannula Cc: Dmitry Torokhov , "STenyaK (Bruno Gonzalez)" , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org ------=_Part_6263_4452801.1171640634515 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2/15/07, Anssi Hannula wrote: > > Dmitry Torokhov wrote: > > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > >> Sorry for not providing a proper patch, could you please also add > >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > >> to the list? I tested it here and that wheel is also working. > >> > > > > OK. > > > > Hmm.. Shouldn't an entry also be added to the devices[] list in > hid-lgff.c for these devices? (and it seems one device is already > missing from there in the current kernel). > > I'm not able to check right now, but I think some earlier kernels may > have defaulted to ff_joystick if no entry is present in devices[], hence > these devices working for some without the entry. > (so the alternative is to restore that behaviour) Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and I guess Valentin made his original patch on a kernel where defaulting was still there. I'll send a separate mail with the patch adding the devices there too, but I personally think defaulting was nice. Was there a reason behind the removal? -- Johann ------=_Part_6263_4452801.1171640634515 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2/15/07, Anssi Hannula <anssi.hannula@gmail.com> wrote:
Dmitry Torokhov wrote:
> On 2/15/07, STenyaK (Bruno Gonzalez) <stenyak@gmail.com> wrote:
>> Sorry for not providing a proper patch, could you please also add
>>         {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel
>> to the list? I tested it here and that wheel is also working.
>>
>
> OK.
>

Hmm.. Shouldn't an entry also be added to the devices[] list in
hid-lgff.c for these devices? (and it seems one device is already
missing from there in the current kernel).

I'm not able to check right now, but I think some earlier kernels may
have defaulted to ff_joystick if no entry is present in devices[], hence
these devices working for some without the entry.
(so the alternative is to restore that behaviour)

Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and I guess Valentin made his original patch on a kernel where defaulting was still there.
I'll send a separate mail with the patch adding the devices there too, but I personally think defaulting was nice. Was there a reason behind the removal?

--
Johann

------=_Part_6263_4452801.1171640634515-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Added device to hid-ff Date: Fri, 16 Feb 2007 11:03:14 -0500 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> <45D4B9AB.70509@gmail.com> <38b3b7c0702160743g67ae3e55pbccad84eefc2368b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <38b3b7c0702160743g67ae3e55pbccad84eefc2368b@mail.gmail.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: johann deneux Cc: Anssi Hannula , "STenyaK (Bruno Gonzalez)" , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org On 2/16/07, johann deneux wrote: > On 2/15/07, Anssi Hannula wrote: > > Dmitry Torokhov wrote: > > > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > > >> Sorry for not providing a proper patch, could you please also add > > >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > > >> to the list? I tested it here and that wheel is also working. > > >> > > > > > > OK. > > > > > > > Hmm.. Shouldn't an entry also be added to the devices[] list in > > hid-lgff.c for these devices? (and it seems one device is already > > missing from there in the current kernel). > > > > I'm not able to check right now, but I think some earlier kernels may > > have defaulted to ff_joystick if no entry is present in devices[], hence > > these devices working for some without the entry. > > (so the alternative is to restore that behaviour) > > Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and > I guess Valentin made his original patch on a kernel where defaulting was > still there. > I'll send a separate mail with the patch adding the devices there too, but I > personally think defaulting was nice. Was there a reason behind the removal? > Simple oversight. I think we should restore defaulting. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Added device to hid-ff Date: Fri, 16 Feb 2007 12:28:44 -0500 Message-ID: References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> <45D4B9AB.70509@gmail.com> <38b3b7c0702160743g67ae3e55pbccad84eefc2368b@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6316_5549806.1171646924944" Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: johann deneux Cc: Anssi Hannula , "STenyaK (Bruno Gonzalez)" , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org ------=_Part_6316_5549806.1171646924944 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2/16/07, Dmitry Torokhov wrote: > On 2/16/07, johann deneux wrote: > > On 2/15/07, Anssi Hannula wrote: > > > Dmitry Torokhov wrote: > > > > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > > > >> Sorry for not providing a proper patch, could you please also add > > > >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > > > >> to the list? I tested it here and that wheel is also working. > > > >> > > > > > > > > OK. > > > > > > > > > > Hmm.. Shouldn't an entry also be added to the devices[] list in > > > hid-lgff.c for these devices? (and it seems one device is already > > > missing from there in the current kernel). > > > > > > I'm not able to check right now, but I think some earlier kernels may > > > have defaulted to ff_joystick if no entry is present in devices[], hence > > > these devices working for some without the entry. > > > (so the alternative is to restore that behaviour) > > > > Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and > > I guess Valentin made his original patch on a kernel where defaulting was > > still there. > > I'll send a separate mail with the patch adding the devices there too, but I > > personally think defaulting was nice. Was there a reason behind the removal? > > > > Simple oversight. I think we should restore defaulting. > Something like the attached should do I think... -- Dmitry ------=_Part_6316_5549806.1171646924944 Content-Type: text/plain; name=hid-lgff-default-to-joystick.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_ey8wayne Content-Disposition: attachment; filename="hid-lgff-default-to-joystick.patch" SW5wdXQ6IGhpZC1sZ2ZmIC0gdHJlYXQgZGV2aWNlcyBhcyBqb3lzdGlja3MgdW5sZXNzIHRvbGQg b3RoZXJ3aXNlCgpCeSBkZWZhdWx0IHRocmVhdCBkZXZpY2VzIGFzIGpveXN0aWNrcyB3aXRoIGNv bnN0YW50IGZvcmNlLWZlZWRiYWNrCmVmZmVjdC4KClNpZ25lZC1vZmYtYnk6IERtaXRyeSBUb3Jv a2hvdiA8ZHRvckBtYWlsLnJ1PgotLS0KIGRyaXZlcnMvdXNiL2lucHV0L2hpZC1sZ2ZmLmMgfCAg IDEwICsrKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCgpJbmRleDogbGludXgvZHJpdmVycy91c2IvaW5wdXQvaGlkLWxnZmYuYwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBsaW51eC5vcmlnL2RyaXZlcnMvdXNiL2lucHV0L2hpZC1sZ2ZmLmMKKysrIGxpbnV4 L2RyaXZlcnMvdXNiL2lucHV0L2hpZC1sZ2ZmLmMKQEAgLTU1LDcgKzU1LDYgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBkZXZfdHlwZSBkZXZpY2VzW10gPQogCXsgMHgwNDZkLCAweGMyOTQsIGZmX2pv eXN0aWNrIH0sCiAJeyAweDA0NmQsIDB4YzI5NSwgZmZfam95c3RpY2sgfSwKIAl7IDB4MDQ2ZCwg MHhjYTAzLCBmZl9qb3lzdGljayB9LAotCXsgMHgwMDAwLCAweDAwMDAsIGZmX2pveXN0aWNrIH0K IH07CiAKIHN0YXRpYyBpbnQgaGlkX2xnZmZfcGxheShzdHJ1Y3QgaW5wdXRfZGV2ICpkZXYsIHZv aWQgKmRhdGEsIHN0cnVjdCBmZl9lZmZlY3QgKmVmZmVjdCkKQEAgLTEwNyw4ICsxMDYsOSBAQCBp bnQgaGlkX2xnZmZfaW5pdChzdHJ1Y3QgaGlkX2RldmljZSogaGlkCiAJc3RydWN0IGlucHV0X2Rl diAqZGV2ID0gaGlkaW5wdXQtPmlucHV0OwogCXN0cnVjdCBoaWRfcmVwb3J0ICpyZXBvcnQ7CiAJ c3RydWN0IGhpZF9maWVsZCAqZmllbGQ7CisJY29uc3Qgc2lnbmVkIHNob3J0ICpmZl9iaXRzID0g ZmZfam95c3RpY2s7CiAJaW50IGVycm9yOwotCWludCBpLCBqOworCWludCBpOwogCiAJLyogRmlu ZCB0aGUgcmVwb3J0IHRvIHVzZSAqLwogCWlmIChsaXN0X2VtcHR5KHJlcG9ydF9saXN0KSkgewpA QCAtMTMyLDEyICsxMzIsMTQgQEAgaW50IGhpZF9sZ2ZmX2luaXQoc3RydWN0IGhpZF9kZXZpY2Uq IGhpZAogCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGRldmljZXMpOyBpKyspIHsKIAkJaWYg KGRldi0+aWQudmVuZG9yID09IGRldmljZXNbaV0uaWRWZW5kb3IgJiYKIAkJICAgIGRldi0+aWQu cHJvZHVjdCA9PSBkZXZpY2VzW2ldLmlkUHJvZHVjdCkgewotCQkJZm9yIChqID0gMDsgZGV2aWNl c1tpXS5mZltqXSA+PSAwOyBqKyspCi0JCQkJc2V0X2JpdChkZXZpY2VzW2ldLmZmW2pdLCBkZXYt PmZmYml0KTsKKwkJCWZmX2JpdHMgPSBkZXZpY2VzW2ldLmZmOwogCQkJYnJlYWs7CiAJCX0KIAl9 CiAKKwlmb3IgKGkgPSAwOyBmZl9iaXRzW2ldID49IDA7IGkrKykKKwkJc2V0X2JpdChmZl9iaXRz W2ldLCBkZXYtPmZmYml0KTsKKwogCWVycm9yID0gaW5wdXRfZmZfY3JlYXRlX21lbWxlc3MoZGV2 LCBOVUxMLCBoaWRfbGdmZl9wbGF5KTsKIAlpZiAoZXJyb3IpCiAJCXJldHVybiBlcnJvcjsK ------=_Part_6316_5549806.1171646924944--